This repository was archived by the owner on Mar 13, 2025. It is now read-only.
Updated to use react-select's AsyncCreatableSelect for getting sugges… #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions in AddModal - Removed CreatableSelect from ReactSelect component - Created new AsyncSelect component - Decoupled suggestion state from redux - Allow AsyncSelect to handle its own state
maxceem
approved these changes
Feb 24, 2021
There was a problem hiding this comment.
Thank you @mbaghel. It works good and became much simpler.
The issue could be sometimes reproduced, but looks like it's less often now, it's harder to reproduce it for me during normal usage. We would check how it goes in daily usage in comparison with the approach we have in Connect App.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tions in AddModal