This repository was archived by the owner on Mar 13, 2025. It is now read-only.
fix: issue #19 #104
Merged
fix: issue #19 #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage popup state with redux so it can be opened by calling a function and does not require props.
…ished implementing report popup and connected to API
maxceem
suggested changes
Feb 19, 2021
There was a problem hiding this comment.
Thank you, @mbaghel it works great and code quality is really amazing.
There are just a few small issues:
-
If I disable the Network and try to submit the report I would see an error:
- this is not a server error. If there is no response with error from the server we can show an empty error message (still keep the title
Report faield).
- this is not a server error. If there is no response with error from the server we can show an empty error message (still keep the title
-
Typo: when we send data we should send
projectIdinstead ofprojected.
…error message for server errors.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds report an issue interface.