Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$25] Skills Popup Improvements: Open on hover any skills #86

Closed
maxceem opened this issue Feb 13, 2021 · 12 comments
Closed

[$25] Skills Popup Improvements: Open on hover any skills #86

maxceem opened this issue Feb 13, 2021 · 12 comments

Comments

@maxceem
Copy link
Contributor

maxceem commented Feb 13, 2021

Follow up from: #36

The skill match popup is displayed only when the number of skills are more and we have a more link. We should have the popup show up on mouse over the "% skill matched" text, so its available for all cases. This is because now the popup is not just a list of extra skills that you cant show on the page and has extra information.

image

Sum up:

  • we have update component, so the skills popup is shown when we put mouse or click on any place, even if we don't have more link. But keep the more text too (keep it blue).

    image

    image

  • Make sure, that if we put mouse on the empty space after the skills, the popup is NOT shown:

    image

@maxceem maxceem added CF enhancement New feature or request labels Feb 13, 2021
@maxceem maxceem changed the title Skills Popup Improvements: Open on hover any skills [$25] Skills Popup Improvements: Open on hover any skills Feb 13, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Feb 13, 2021

Challenge https://www.topcoder.com/challenges/5565ad9e-846e-4e04-bdec-acdb01c417a0 has been created for this ticket.

This is an automated message for maxceem via Topcoder X

@yoution
Copy link
Contributor

yoution commented Feb 13, 2021

@bug-bash-helper assign

@bug-bash-hunt-helper
Copy link

@yoution ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

@maxceem
Copy link
Contributor Author

maxceem commented Feb 13, 2021

Challenge https://www.topcoder.com/challenges/5565ad9e-846e-4e04-bdec-acdb01c417a0 has been assigned to yoution.

This is an automated message for maxceem via Topcoder X

@yoution
Copy link
Contributor

yoution commented Feb 13, 2021

@bug-bash-helper #95 is ready for review

@bug-bash-hunt-helper
Copy link

@yoution ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

yoution added a commit to yoution/taas-app that referenced this issue Feb 14, 2021
maxceem added a commit that referenced this issue Feb 16, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
fix: issue #86
@sandhiyakavi
Copy link
Collaborator

@maxceem If we click any of the skills, a black rectangular box is showing around the displayed skills.

image

Other than that the skills are correctly displaying when hovered over

image

@maxceem
Copy link
Contributor Author

maxceem commented Feb 18, 2021

@sandhiyakavi the border when clicking is removed now by 27a6277. Could you please check again?

@sandhiyakavi
Copy link
Collaborator

Verified. Border is not displaying now and Working as expected.

image

@maxceem
Copy link
Contributor Author

maxceem commented Feb 19, 2021

Payment failed: [400]: Failed to activate challenge. Detail: Cannot Activate this project, it has no active billing accounts.

This is an automated message for maxceem via Topcoder X

@maxceem maxceem reopened this Feb 19, 2021
@maxceem maxceem closed this as completed Feb 21, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Feb 21, 2021

Payment task has been updated: https://www.topcoder.com/challenges/5565ad9e-846e-4e04-bdec-acdb01c417a0
Payments Complete
Winner: yoution
Copilot: maxceem
Challenge 5565ad9e-846e-4e04-bdec-acdb01c417a0 has been paid and closed.

This is an automated message for maxceem via Topcoder X

@maxceem maxceem reopened this Feb 21, 2021
@codejamtc
Copy link
Collaborator

Fixed: 🆗 in Production via milestone v1.5

bandicam 2021-02-25 20-39-14-714

bandicam.2021-02-25.20-39-17-631.mp4
bandicam.2021-02-25.20-41-06-801.mp4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants