Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$15] Search/filter field should be on the right on Desktop #81

Closed
maxceem opened this issue Feb 10, 2021 · 24 comments
Closed

[$15] Search/filter field should be on the right on Desktop #81

maxceem opened this issue Feb 10, 2021 · 24 comments

Comments

@maxceem
Copy link
Contributor

maxceem commented Feb 10, 2021

See design https://marvelapp.com/prototype/921gg0f/screen/73987506/handoff
This was initially implemented the correct way, but after some moment it jumps down. Maybe it's because of the styles priority. Don't use important to fix it.

image
image

@maxceem maxceem added the bug Something isn't working label Feb 10, 2021
@maxceem maxceem changed the title Search/filter field should be on the right on Desktop [$15] Search/filter field should be on the right on Desktop Feb 13, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Feb 13, 2021

Challenge https://www.topcoder.com/challenges/661b1864-c7e7-4675-a306-e809926c54b3 has been created for this ticket.

This is an automated message for maxceem via Topcoder X

@yoution
Copy link
Contributor

yoution commented Feb 13, 2021

@bug-bash-helper assign

@bug-bash-hunt-helper
Copy link

@yoution ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

@maxceem
Copy link
Contributor Author

maxceem commented Feb 13, 2021

Challenge https://www.topcoder.com/challenges/661b1864-c7e7-4675-a306-e809926c54b3 has been assigned to yoution.

This is an automated message for maxceem via Topcoder X

@yoution
Copy link
Contributor

yoution commented Feb 13, 2021

image
@maxceem how to reproduce it?

@yoution
Copy link
Contributor

yoution commented Feb 13, 2021

I can not reproduce the issue ,maybe have fixed

@yoution yoution removed their assignment Feb 13, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Feb 13, 2021

Challenge https://www.topcoder.com/challenges/661b1864-c7e7-4675-a306-e809926c54b3 yoution has been unassigned.

This is an automated message for maxceem via Topcoder X

@maxceem
Copy link
Contributor Author

maxceem commented Feb 13, 2021

@yoution try here https://platform.topcoder-dev.com/taas/myteams

image

I guess it's caused by the order in which styles are loading. So sometimes it's good, and sometimes no. I think we need to make sure that styles have the correct priority no matter what was the order of loading.

@yoution
Copy link
Contributor

yoution commented Feb 13, 2021

@bug-bash-helper assign

@bug-bash-hunt-helper
Copy link

@yoution 🛑 this issue is not open for pick up.

You may only pickup issues which are included in this Bug Bash and open for pick up.
Such issues have open status and have labels CF and Open for Pickup.

@yoution
Copy link
Contributor

yoution commented Feb 13, 2021

@bug-bash-helper assign

@bug-bash-hunt-helper
Copy link

@yoution 🛑 this issue is not open for pick up.

You may only pickup issues which are included in this Bug Bash and open for pick up.
Such issues have open status and have labels CF and Open for Pickup.

@maxceem
Copy link
Contributor Author

maxceem commented Feb 13, 2021

@yoution, please, try one more time.

@maxceem
Copy link
Contributor Author

maxceem commented Feb 13, 2021

@yoution to unassign yourself, please, use command @bug-bash-helper unassign, then it would work well and you could assign it again if you want. Don't unassign yourself manually.

@bug-bash-hunt-helper
Copy link

@maxceem 🛑 I cannot unassign you from this issue because you are not assigned.

@yoution
Copy link
Contributor

yoution commented Feb 13, 2021

@bug-bash-helper assign

@bug-bash-hunt-helper
Copy link

@yoution ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

@maxceem
Copy link
Contributor Author

maxceem commented Feb 13, 2021

Challenge https://www.topcoder.com/challenges/661b1864-c7e7-4675-a306-e809926c54b3 has been assigned to yoution.

This is an automated message for maxceem via Topcoder X

@yoution
Copy link
Contributor

yoution commented Feb 13, 2021

Ready for Review": "@bug-bash-helper #89 is ready for review"

@bug-bash-hunt-helper
Copy link

@yoution ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

@maxceem maxceem added Feedback The issue hasn't been fixed completely and some feedback has been provided. and removed Ready for Review labels Feb 16, 2021
maxceem added a commit that referenced this issue Feb 17, 2021
@maxceem maxceem added ACCEPTED tcx_FixAccepted Ready for DEV QA and removed Feedback The issue hasn't been fixed completely and some feedback has been provided. labels Feb 17, 2021
@sandhiyakavi
Copy link
Collaborator

Verified on Dev. Working as expected.

image
image

From Mobile
93923
32221

@maxceem
Copy link
Contributor Author

maxceem commented Feb 19, 2021

Payment failed: [400]: Failed to activate challenge. Detail: Cannot Activate this project, it has no active billing accounts.

This is an automated message for maxceem via Topcoder X

@maxceem maxceem reopened this Feb 19, 2021
@maxceem maxceem closed this as completed Feb 21, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Feb 21, 2021

Payment task has been updated: https://www.topcoder.com/challenges/661b1864-c7e7-4675-a306-e809926c54b3
Payments Complete
Winner: yoution
Copilot: maxceem
Challenge 661b1864-c7e7-4675-a306-e809926c54b3 has been paid and closed.

This is an automated message for maxceem via Topcoder X

@maxceem maxceem reopened this Feb 21, 2021
@codejamtc
Copy link
Collaborator

Fixed: 🆗 in Production via milestone v1.5

Ref: https://marvelapp.com/prototype/921gg0f/screen/73987506/handoff

Desktop:

bandicam 2021-02-25 21-47-31-986
bandicam 2021-02-25 21-47-39-576

Mobile:

bandicam 2021-02-25 21-48-17-321

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants