Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$40] Update Team Details Button Language & Candidate Selection Screen #80

Closed
wdprice opened this issue Feb 5, 2021 · 19 comments
Closed

Comments

@wdprice
Copy link

wdprice commented Feb 5, 2021

Update Button Text on Team Details Page:
Original Language: "Select Candidates"
New Language: "Review Candidates"
image

Add an icon to the "To Review" tab when users appear on that list.
image

If the user opens the page and there are No records in the "To Review" list, default the view to the "Interested" Tab

@wdprice wdprice added the enhancement New feature or request label Feb 5, 2021
@wdprice
Copy link
Author

wdprice commented Feb 5, 2021

@maxceem - think this may be a small one - would be great to knock it out in this next release if possible.

If you need an icon for this, let me know and we can get it worked on.

@maxceem
Copy link
Contributor

maxceem commented Feb 6, 2021

@wdprice yes, we can include this into the release. Having an icon would be great, as I don't see any suitable one in the current design.

@maxceem maxceem added the help wanted Extra attention is needed label Feb 6, 2021
@maxceem
Copy link
Contributor

maxceem commented Feb 11, 2021

@wdprice would you like to use some particular icon for this? Or should we find some one our taste?

@maxceem
Copy link
Contributor

maxceem commented Feb 13, 2021

@wdprice what if we do like this (I'm trying to reusing existent styles from other pages from the provided Marvel design):

image

@maxceem maxceem added the CF label Feb 13, 2021
@maxceem
Copy link
Contributor

maxceem commented Feb 13, 2021

Sum up:

@maxceem maxceem changed the title Update Team Details Button Language & Candidate Selection Screen [$40] Update Team Details Button Language & Candidate Selection Screen Feb 13, 2021
@maxceem
Copy link
Contributor

maxceem commented Feb 13, 2021

Challenge https://www.topcoder.com/challenges/020758b9-4517-4eb4-8a6f-9501572296dc has been created for this ticket.

This is an automated message for maxceem via Topcoder X

@yoution
Copy link
Contributor

yoution commented Feb 13, 2021

@bug-bash-helper assign

@bug-bash-hunt-helper
Copy link

@yoution ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

@maxceem
Copy link
Contributor

maxceem commented Feb 13, 2021

Challenge https://www.topcoder.com/challenges/020758b9-4517-4eb4-8a6f-9501572296dc has been assigned to yoution.

This is an automated message for maxceem via Topcoder X

yoution added a commit to yoution/taas-app that referenced this issue Feb 13, 2021
@yoution
Copy link
Contributor

yoution commented Feb 13, 2021

@bug-bash-helper #91 is ready for review

@bug-bash-hunt-helper
Copy link

@yoution ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

@maxceem maxceem added Feedback The issue hasn't been fixed completely and some feedback has been provided. and removed Ready for Review labels Feb 16, 2021
maxceem added a commit that referenced this issue Feb 17, 2021
@maxceem maxceem added ACCEPTED tcx_FixAccepted and removed Feedback The issue hasn't been fixed completely and some feedback has been provided. labels Feb 17, 2021
maxceem added a commit that referenced this issue Feb 17, 2021
@sandhiyakavi
Copy link
Collaborator

@maxceem If there are No records in the "To Review" list, it is not defaulting the view to the "Interested" Tab

issue.80.mp4

Other functionalities are working fine

image
image

@maxceem
Copy link
Contributor

maxceem commented Feb 18, 2021

If there are No records in the "To Review" list, it is not defaulting the view to the "Interested" Tab

This is fixed by 9907a4f

@sandhiyakavi could you please try now.

@sandhiyakavi
Copy link
Collaborator

Verified on Dev. Working as expected.

issue.80.2.mp4

@maxceem
Copy link
Contributor

maxceem commented Feb 19, 2021

Payment failed: [400]: Failed to activate challenge. Detail: Cannot Activate this project, it has no active billing accounts.

This is an automated message for maxceem via Topcoder X

@maxceem maxceem reopened this Feb 19, 2021
@maxceem maxceem closed this as completed Feb 21, 2021
@maxceem
Copy link
Contributor

maxceem commented Feb 21, 2021

Payment task has been updated: https://www.topcoder.com/challenges/020758b9-4517-4eb4-8a6f-9501572296dc
Payments Complete
Winner: yoution
Copilot: maxceem
Challenge 020758b9-4517-4eb4-8a6f-9501572296dc has been paid and closed.

This is an automated message for maxceem via Topcoder X

@maxceem maxceem reopened this Feb 21, 2021
@codejamtc
Copy link
Collaborator

Fixed: 🆗 in Production via milestone v1.5

  • Update Button Text on Team Details Page: Original Language: "Select Candidates", New Language: "Review Candidates"
    image
  • Add an icon to the "To Review" tab when users appear on that list.
  • If the user opens the page and there are No records in the "To Review" list, default the view to the "Interested" Tab
bandicam.2021-02-26.08-02-26-909.mp4

bandicam 2021-02-26 08-05-00-394
bandicam 2021-02-26 08-05-08-016
bandicam 2021-02-26 08-05-16-789

@codejamtc
Copy link
Collaborator

@lakshmiathreya

@sandhiyakavi
Copy link
Collaborator

Verified in Prod Env.

image

image
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants