Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$150] Show syncing message and wait if calendar is not yet synced when scheduling interview #588

Open
maxceem opened this issue Dec 6, 2021 · 8 comments

Comments

@maxceem
Copy link
Contributor

maxceem commented Dec 6, 2021

We can schedule an interview with a connected Google/Microsoft calendar or without connected calendar (it would use Nyals virtual calendar internally).

When we connect Google/Microsoft calendar successfully it might still take time to sync it in the background, and until then we cannot schedule an interview. So when we schedule interview we have to check if calendar was already synced, and if no, then show loading indicator until calendar is fully synced.

image

When the user clicks "confirm" we have to check if the current primary l calendar has calendarId.

Verification

We have to verify this somehow when working locally. As this issue would happen only when we connect Google/Microsoft account the first time it would be better to find some other way for testing.

  • For example, run TaaS API locally and manually changing the value in DB and reindex data to ES
  • Or create some kind of proxy and override that value in the endpoint on the fly. For example by creating proxy similar to this one recommender-proxy.zip if this possible.
@maxceem maxceem changed the title Show syncing message and wait if calendar is not yet synced when scheduling interview [$80] Show syncing message and wait if calendar is not yet synced when scheduling interview Dec 6, 2021
@maxceem maxceem added this to the Interview Update (Nylas) milestone Dec 6, 2021
@maxceem maxceem changed the title [$80] Show syncing message and wait if calendar is not yet synced when scheduling interview [$150] Show syncing message and wait if calendar is not yet synced when scheduling interview Dec 8, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Dec 8, 2021

@yoution @mahidulalvi-bonic feel free to pick up this issue if you could work on it during the next 24 hours.

Please, note, we would have to create some way to verify it locally. If something is not clear, please, let me know.

@ghost
Copy link

ghost commented Dec 8, 2021

@maxceem, I can work on it. Seeing the message just now, how long do I have to finish this?

@maxceem
Copy link
Contributor Author

maxceem commented Dec 9, 2021

@mahidulalvi-bonic 2 days would be good, or let me know how long do you think it would take for you?

@ghost
Copy link

ghost commented Dec 10, 2021

@maxceem, Monday is more ideal for me. I can work long during the weekend. Please let me know if it works.

@maxceem
Copy link
Contributor Author

maxceem commented Dec 10, 2021

Ok, @mahidulalvi-bonic by Monday works for us.

@sdgun
Copy link

sdgun commented Dec 21, 2021

Verified in Dev

2021-12-21_14-00-30.mp4

@maxceem
Copy link
Contributor Author

maxceem commented Dec 21, 2021

@maxceem maxceem added the PAID label Dec 21, 2021
@sdgun sdgun removed this from the Interview Update (Nylas) milestone Apr 5, 2022
@sdgun
Copy link

sdgun commented Apr 5, 2022

Removing the milestone since this feature was disabled in the current production release #598

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants