Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$70] When a custom role is added, the job description is not saved #516

Closed
sdgun opened this issue Oct 19, 2021 · 12 comments
Closed

[$70] When a custom role is added, the job description is not saved #516

sdgun opened this issue Oct 19, 2021 · 12 comments

Comments

@sdgun
Copy link

sdgun commented Oct 19, 2021

Steps
Go to JD flow and make a search with a job description which doesn't have skills matching any existing roles
Proceed and create the team
check the created position in TAAS TEAMS page

The job description is missing

image

CC @nikolay83

@sdgun sdgun added bug Something isn't working P2 Role-Matching-Intake labels Oct 19, 2021
@maxceem
Copy link
Contributor

maxceem commented Oct 20, 2021

Summary

The Job Description should depend on way customer creates a talent request https://platform.topcoder-dev.com/taas/createnewteam:

image

  • Search by Role - Should be the canned job description provided for the Roles (Java Spring, React, Data Engineer, Salesforce, etc)

    image

  • Search by Skill - for now, just the list of skills

    image

  • Describe the work - it should be the same Description which user entered during requesting a talent

    image

Notes

PR

  • This fix has to be done using master branch, so we could deploy fix to Production immediately after fixing and testing. If API need to be fixed, the fix has to be also applied to the master.

@maxceem maxceem changed the title When a custom role is added, the job description is not saved [$70] When a custom role is added, the job description is not saved Oct 20, 2021
@maxceem
Copy link
Contributor

maxceem commented Oct 20, 2021

@yoution @mbaghel if you believe that you can solve this issue during 12 hours, please, feel free to pick it up.
The first who comments on this may start working immediately.

@yoution
Copy link
Contributor

yoution commented Oct 20, 2021

@maxceem please assign to me

@maxceem
Copy link
Contributor

maxceem commented Oct 20, 2021

Sure, assigned @yoution

yoution added a commit to yoution/taas-apis that referenced this issue Oct 21, 2021
yoution added a commit to yoution/taas-app that referenced this issue Oct 21, 2021
@yoution
Copy link
Contributor

yoution commented Oct 21, 2021

@maxceem please review

@maxceem
Copy link
Contributor

maxceem commented Oct 21, 2021

@yoution when I create team using skills the job description is empty, see demo video https://monosnap.com/file/ewfGYjX5jorS9CzPcNtUDQUGdfCfhH. But it has to be a comma-separated list of skills.

Other 2 cases work good for me.

@yoution
Copy link
Contributor

yoution commented Oct 21, 2021

@maxceem did you deploy the tass-api project?

@maxceem
Copy link
Contributor

maxceem commented Oct 21, 2021

ah, yes, my fault, I deployed it but forgot to change the API URL to local one, testing...

@maxceem
Copy link
Contributor

maxceem commented Oct 21, 2021

Thank you @yoution it works good as per local testing, passing for QA.

@sdgun this issue is ready for testing on DEV https://platform.topcoder-dev.com/taas/createnewteam

@sdgun
Copy link
Author

sdgun commented Oct 22, 2021

Verified all the 3 flows in Dev, the Job description is saved as expected.

@maxceem
Copy link
Contributor

maxceem commented Oct 22, 2021

@maxceem maxceem added this to the TaaS Intake 1.3 milestone Oct 27, 2021
@sdgun
Copy link
Author

sdgun commented Oct 27, 2021

Verified in prod

2021-10-27_15-34-51.mp4

@sdgun sdgun closed this as completed Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants