Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

The amount calculation is incorrect #443

Closed
sdgun opened this issue Aug 10, 2021 · 6 comments
Closed

The amount calculation is incorrect #443

sdgun opened this issue Aug 10, 2021 · 6 comments

Comments

@sdgun
Copy link

sdgun commented Aug 10, 2021

Steps
Log in from an external user
select a role/skill and continue
On the Team details page, increase the number of resources to more than 1
go to checkout page and see the amounts

The Charge should be for the first week for the request using the global rate, and this should be multiplied based on the number of resources. The total deposit should be the total charges for the roles in the left side

But the implementation only shows the global rate irrespective of the number of resources(resource count is always 1 issue #442) and the total deposit is calculated by multiplying the global rate of each role by 4(weeks)

Also when the user selects 30 hr/week or 20 hr/week, it still takes the 40 hr/week rate in the calculation

2021-08-10_15-46-49.mp4

@wdprice pls correct me if I am wrong

@nikolay83
Copy link
Collaborator

@sdgun works fine for me. Can you recheck please?

@sdgun
Copy link
Author

sdgun commented Aug 10, 2021

@nikolay83 Are we on the same page here? I rechecked it and I can still see the same issues. For ex I select .net engineer and I see role rate 50 and total deposit 200, which should be 50 since 1 resource X 1 week.

image

@nikolay83
Copy link
Collaborator

@arpitchaudhari
The amount in the summary is calculated correctly.
However the total deposit is wrong:
AS IS - the amounts from summary multipied by number of weeks
TO BE: just the total of amounts from summary. I.e. we charge only 1 week worth deposit.

@ghost
Copy link

ghost commented Aug 11, 2021

Issue Resolved.

Image 11-08-21 at 9 04 AM

nikolay83 added a commit to topcoder-platform/taas-apis that referenced this issue Aug 11, 2021
nikolay83 added a commit to topcoder-platform/taas-apis that referenced this issue Aug 11, 2021
@sdgun
Copy link
Author

sdgun commented Aug 11, 2021

Verified in Dev, the amounts are correctly calculated.

image

@sdgun
Copy link
Author

sdgun commented Aug 16, 2021

Verified in production.

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants