Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Update Match Found Screen #412

Closed
wdprice opened this issue Jul 26, 2021 · 25 comments
Closed

Update Match Found Screen #412

wdprice opened this issue Jul 26, 2021 · 25 comments

Comments

@wdprice
Copy link

wdprice commented Jul 26, 2021

Update to the Successful match screen: https://marvelapp.com/prototype/89c7i66/screen/81081386

Note: while the updated design does not contain this element, please keep it at the bottom of the element, along witht he full time / part time feature:
image

@cagdas001
Copy link
Contributor

@nikolay83 Does this apply only to the Skills and Job Description results? The Role page doesn't involve a skill search & matching process.

@nikolay83
Copy link
Collaborator

@cagdas001
yes, correct.

@yoution
Copy link
Contributor

yoution commented Aug 2, 2021

@nikolay83 can you give me some test data?
I can not understand the requirement very clear
if I input nginx and .net it return
image

but the BE not return which skill is matched? so I need to change the BE API?

if I input nginx and javascript it return no matched, why?

@yoution
Copy link
Contributor

yoution commented Aug 2, 2021

I know, we do not to modify the BE api

@yoution
Copy link
Contributor

yoution commented Aug 2, 2021

@nikolay83 how about these ones?
the role has these skills, but not search by the request?
image

@yoution
Copy link
Contributor

yoution commented Aug 2, 2021

@nikolay83 is there any skill api, I can use to get skill id by skillname, in order to show to skill image , we should get the skill id first

@nikolay83
Copy link
Collaborator

  1. Yes, it returns the number of skills matched in the role found.
  2. Yes, you have to adjust the back-end to return the skills matched (and requested but unmatched if technically necessary, up to you). Let me know it makes the dev more expensive.
  3. For nginx and javascript probably there is no role matching both skills at prod (or whatever environment you have). Or is there?

yoution added a commit to yoution/taas-app that referenced this issue Aug 2, 2021
nikolay83 added a commit that referenced this issue Aug 2, 2021
@sdgun
Copy link

sdgun commented Aug 3, 2021

@nikolay83

  1. The members matched section is auto adjusted when there are more than 4-5 skills.
  2. The description doesn't match with the design

App:
image

Design:
image

@wdprice
Copy link
Author

wdprice commented Aug 3, 2021

The skills matched should show the skills the customer identified, not the skills on the role. So if a Customer inputs: "React.js, Node.js, .NET, SCSS" , then those 4 should be shown, with React, Node and SCSS highlighted.

Always put the customers top N skills on the top of the list.

@yoution
Copy link
Contributor

yoution commented Aug 4, 2021

@wdprice @nikolay83 Could you please explain elaborately,
if we input skillA, skilB, skillC, skillD, then BE get a Role, which has skill A SkillB, skillE, so we should show SKillA, SkillB highlight,
and disable SkillC, SkillD

@wdprice
Copy link
Author

wdprice commented Aug 4, 2021

You are correct @yoution. By disable, I assume you are saying it will be displayed, but "grayed out"

yoution added a commit to yoution/taas-app that referenced this issue Aug 4, 2021
nikolay83 added a commit that referenced this issue Aug 5, 2021
@sdgun
Copy link

sdgun commented Aug 5, 2021

@yoution @wdprice This scenario is something that doesn't happen according to the current implementation, because when a search is made for skillA, skilB, skillC, skillD we never return a role which doesn't have all those skills. In such scenarios we return custom role.

@wdprice @nikolay83 Could you please explain elaborately,
if we input skillA, skilB, skillC, skillD, then BE get a Role, which has skill A SkillB, skillE, so we should show SKillA, SkillB highlight,
and disable SkillC, SkillD

@yoution
Copy link
Contributor

yoution commented Aug 5, 2021

@sdgun there is a rate, if matched rate below that value, will return custom role, current rate maybe 0.7

@sdgun
Copy link

sdgun commented Aug 5, 2021

@yoution So we only allow user to select up to 3 skills max, with that this scenario cannot happen right?

@yoution
Copy link
Contributor

yoution commented Aug 5, 2021

@sdgun no, if BE config the match-rate is 0.7, if you input skillA,skillB,skillC,skillD, but the role has skillA, skillB, skillC, so current the matching-rate is 3/4 = 0.75, so the vaule is more than 0.7, will return role, if the role only has skillA, skillB,
the matching-rate is 2/4 = 0.5, so current value is less than 0.7, so will return custom role

@sdgun
Copy link

sdgun commented Aug 5, 2021

@yoution since we only allow max 3 skills from UI, the max value rate can go only up to 0.66(ex- looking for skilla, skillb, skillc and role has only 2 of them, so 2/3) which is less than 0.7 and returns custom role. So this grayed out skills we cannot test with current UI restriction?

@wdprice
Copy link
Author

wdprice commented Aug 5, 2021

@sdgun - we can update the match threshold pretty easily - I am OK with updating to .66 so we can get matches on 2 out of 3.

@wdprice
Copy link
Author

wdprice commented Aug 6, 2021

@nikolay83 @yoution - one thing I noticed in my recent tests - we are still showing the old match screen when the user taks the "Select a Role" path.

For that path only can we use the new screen and show all the skills related to the Role? Current functionality for job description and input skills is great, just the role path would be affected by this request.

@wdprice
Copy link
Author

wdprice commented Aug 9, 2021

@nikolay83 - did you see the above comment? Want to get this update in before we launch.

@sdgun
Copy link

sdgun commented Aug 10, 2021

Verified the UI issue of members matched section shrinking. but didn't verify the skills disabling since match rate is 7. Not closing the issue since the above issue reported by Will

@sdgun
Copy link

sdgun commented Aug 11, 2021

Removing Ready for Dev QA label since #412 (comment) is pending

@nikolay83
Copy link
Collaborator

@yoution
Will's request was : for "Select Roles" path only can we use the new screen and show all the skills related to the Role.

@yoution
Copy link
Contributor

yoution commented Aug 11, 2021

ok, I will add it

@sdgun
Copy link

sdgun commented Aug 11, 2021

Verified both disable skills with match rate .66 and the role flow showing all skills highlighted.

image

image

@sdgun
Copy link

sdgun commented Aug 16, 2021

Verified in production.

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants