Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Add All Full or Part Time selector #407

Closed
wdprice opened this issue Jul 23, 2021 · 7 comments
Closed

Add All Full or Part Time selector #407

wdprice opened this issue Jul 23, 2021 · 7 comments

Comments

@wdprice
Copy link

wdprice commented Jul 23, 2021

Add a new column on the match made screen and the review screen before submission.

Title: Full or Part Time
Type: Picklist
Values: "Full Time - 40hr/wk", "Part Time - 30hr/wk", "Part Time - 20hr/wk"
Default Value: "Full Time - 40hr/wk"

image

cagdas001 added a commit to cagdas001/taas-apis that referenced this issue Jul 27, 2021
* Accept `hoursPerWeek` for jobs, when creating a team.
* Fix `getSkillIdsByNames` to return ids in the exact same order of names.
* Include skill ids in `getSkillsByJobDescription` response

Addresses topcoder-archive/topcoder-platform-taas-app#400, topcoder-archive/topcoder-platform-taas-app#407
nikolay83 added a commit that referenced this issue Jul 27, 2021
feat: polish release - v1.2 - Milestone19. Addresses #400, #401, #402, #404, #406, #407.
@sdgun
Copy link

sdgun commented Jul 28, 2021

@nikolay83 When a part time option is selected from 'Full or Part Time' drop down, TAAS Team still shows the workload as Full-time. Just checking if this value has anything to with the value displayed in the job details of the selected position in the Team.

image

@cagdas001
Copy link
Contributor

The workload is another field:
chrome_2021-07-28_12-19-09

The new field gets reflected in the hoursPerWeek of jobs.
chrome_2021-07-28_13-53-02

@sdgun
Copy link

sdgun commented Jul 28, 2021

Thanks @cagdas001 I guess there is no direct mapping here with any visible field in the Taas app.

Verified in Dev in Windows chrome/FF & Edge.

image

image

@cagdas001
Copy link
Contributor

I guess there is no direct mapping here with any visible field in the Taas app.

Yeah, I think so. Maybe we should also reflect hoursPerWeek (i.e. the full or part-time selection) somewhere in the UI. And we can automatically set the workload based on this selection as well. It's clear a full-time workload is against the Part Time - 20hr/wk selection

If the team comes up with a decision on this, I'll follow up on this issue

@wdprice
Copy link
Author

wdprice commented Jul 29, 2021

I support the addition of the field to the TaaS App UI, but don't view it as a blocker for this release.

Please post the details of the database field and proposed logic and we'll add something to the backlog.

@cagdas001
Copy link
Contributor

cagdas001 commented Jul 30, 2021

Please post the details of the database field and proposed logic and we'll add something to the backlog.

DB

hours_per_week column of the jobs table

Backend

hoursPerWeek property of jobs

Frontend

As above: hoursPerWeek property of jobs. You should be able to simply access with job.hoursPerWeek.

You'll get an integer value from the backend, denoting the hours per week. So, the value mapping should/will be

Selection Value
Full Time - 40hr/wk 40
Part Time - 30hr/wk 30
Part Time - 20hr/wk 20

The decision of the placement(s) to display this field is up to the product team. (for instance, the page mentioned in #407 (comment) or any other place(s))

Additional Context

  • Ideally, there should also be some checks at the backend to get consistent values. For e.g. the workload full-time is against the Part Time selection(s).
  • It should be possible to do this via conditional JOI validations.
  • Frontend also should automatically adjust these values before posting the request. So, if Part Time is selected, the workload of the job should be fractional and so on

@sdgun
Copy link

sdgun commented Aug 16, 2021

Verified in production.

image

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants