-
Notifications
You must be signed in to change notification settings - Fork 24
Restrict the duration field on Jobs to a 4 week minimum #383
Comments
Sum up:
|
thanks for pointing it out @nikolay83, yes, makes sense We would create a constant and reuse it in both places. |
@maxceem Currently we are able to enter floating point values to the duration field, though tooltip is displayed and Create button is hidden, the "Talent as a Service engagements have a 4 week minimum commitment." error message is also shown even if the value is already greater than 4. |
@mbaghel there appears to be one edge case, could please have a look at this. Validation should work well even if enter float number. |
Added a fix #392 |
Thanks, @mbaghel. @sandhiyakavi the issue with decimal numbers is fixed and ready for testing on DEV. |
@maxceem There is an issue while editing the Job, Save button is not getting enabled in Editing Job screen if the duration field is null. Save button is getting enabled only if we edit the duration field. Steps to Reproduce:
|
Ah, nice catch @sandhiyakavi. @mbaghel this field is optional. So we may leave it empty and should only check for minimal value if some value is entered into the field. Could you please have a look at this? |
Fixed in #409. I misunderstood how this field should work. |
Thanks @mbaghel it works well for me now. @sandhiyakavi this was fixed and ready for QA. |
Verified in Dev Env. working as expected |
The previous payment was incorrect and was canceled by Topcoder Support. Here is a correct payment https://www.topcoder.com/challenges/ab3b12b0-e89e-40d5-9fa5-92dde9cbb248 |
Task from Will:
This is similar like we did in Connect App appirio-tech/connect-app#4417
The text was updated successfully, but these errors were encountered: