Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$60] Pagination for My Teams Page (list of teams) #37

Closed
maxceem opened this issue Dec 25, 2020 · 8 comments
Closed

[$60] Pagination for My Teams Page (list of teams) #37

maxceem opened this issue Dec 25, 2020 · 8 comments

Comments

@maxceem
Copy link
Contributor

maxceem commented Dec 25, 2020

Implement pagination and filter field for My Teams page:

image

Bellow add pagination like we have on other pages:

image

  • it would on gray background on My Teams Page

  • don't show "Show More" button

  • When we type something inside the filter we should send a request to the server automatically. Use debouncing, so when we type fast, we don't send request on each keypress.

  • Pagination should also be handled server-side.

TaaS API already supports everything we need https://github.com/topcoder-platform/taas-apis/issues?q=is%3Aissue+is%3Aclosed

@maxceem maxceem added the enhancement New feature or request label Dec 25, 2020
@maxceem maxceem changed the title Pagination for My Teams Page (list of teams) [$60] Pagination for My Teams Page (list of teams) Dec 25, 2020
@maxceem
Copy link
Contributor Author

maxceem commented Dec 25, 2020

Contest https://www.topcoder.com/challenges/30160317 has been created for this ticket.

This is an automated message for maxceem via Topcoder X

@yoution
Copy link
Contributor

yoution commented Dec 30, 2020

@maxceem please assign to me

@maxceem
Copy link
Contributor Author

maxceem commented Dec 30, 2020

Contest https://www.topcoder.com/challenges/30160317 has been updated - it has been assigned to yoution.

This is an automated message for maxceem via Topcoder X

yoution added a commit to yoution/taas-app that referenced this issue Jan 3, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Jan 5, 2021

@yoution At the moment we are showing "Loading..." during teams loading. Let's also show it when we change page or when we loading on filter change, so users know that we are loading new data.

Also, can we show the text "Not teams found" if there are not teams?

yoution added a commit to yoution/taas-app that referenced this issue Jan 6, 2021
yoution added a commit to yoution/taas-app that referenced this issue Jan 6, 2021
@sandhiyakavi
Copy link
Collaborator

@maxceem @yoution Filter by Team is not taking space into consideration.

image

Other functionalities are working fine.

@maxceem
Copy link
Contributor Author

maxceem commented Jan 7, 2021

@sandhiyakavi could we please log this as a separate issue?

The thing is that for filtering we use Projects API: https://api.topcoder-dev.com/v5/taas-teams?page=1&perPage=20&name=*taas%20project%20saar* so the Project API mess around with spaces in requests and TaaS App UI just show all the teams which Projects API returns. We can investigate this issue for the next release, as filtering even wasn't a required feature for this release.

@sandhiyakavi
Copy link
Collaborator

Other than the filter issue, other functionalities are working fine.

@maxceem
Copy link
Contributor Author

maxceem commented Jan 8, 2021

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30160317

This is an automated message for maxceem via Topcoder X

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants