Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Job update and Resource Booking update should use PATCH instead of PUT #283

Open
maxceem opened this issue May 27, 2021 · 2 comments
Open
Assignees

Comments

@maxceem
Copy link
Contributor

maxceem commented May 27, 2021

In the TaaS App we have the ability to:

Internally, when save update we use PUT request:

This appears to have a drawback. If we add some new field in the TaaS API but we don't update the form then fields that are not supported by the form would be reset to null and cause issue like this topcoder-platform/taas-apis#260

Taks:

  • we have to use PATCH requests instead of PUT to make it totally safe, so we never would lost any fields
  • we have to make sure that we still can clear data in the form for optional fields and the server would accept it and correctly clear that data
@maxceem
Copy link
Contributor Author

maxceem commented May 27, 2021

QA guidelines:

  • we have to make sure that we can clear any optional value in the RB edit form and Job edit form
  • test create Job

@sandhiyakavi
Copy link
Collaborator

@maxceem Verified the following scenarios,

  1. Verified creating Job from Connect as well as Taas app, its getting created successfully.
  2. Verified Editing Job as well as RB form by clearing all the optional values, it's updating to null.
bandicam.2021-05-28.13-33-53-166.mp4
bandicam.2021-05-28.13-43-12-746.mp4

value updated to null

RB_null

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants