Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Update candidates status #25

Closed
maxceem opened this issue Dec 14, 2020 · 15 comments
Closed

Update candidates status #25

maxceem opened this issue Dec 14, 2020 · 15 comments
Assignees
Labels
enhancement New feature or request QA Pass on Prod

Comments

@maxceem
Copy link
Contributor

maxceem commented Dec 14, 2020

  1. Implement functionality for "Yes"/"No" buttons for candidates.

    • Clicking any of the buttons should disable them, and send a request to the server to update the candidate status: PATHC {{TOPCODER_API_V5}}/jobCandidates/{{jobCandidateId}} with body { "status": "..." }.
    • "Yes" should update status to "shortlist", "No" - to "rejected"
    • If the request is successful, the candidate should be moved to appropriate tab withot page reloading, and without reloading of the whole list of the candidates.
      • Also, show a toastr success popup "Candidate shorlisted" / "Candidate rejected".
    • In case of error, buttons should become enabled again, candidate stays where it was before and show red toastr popup "Failed to shortlist candidate" / "Failed to reject candidate"

    image

  2. Remove the "Schedule interview" button for now

    image

General requirements

For this feature, we have to create a Redux store with actions. So we would keep the job with job candidates in Redux store, call actions to change status, and update data in store after successful requests without data realoding.

@maxceem maxceem added enhancement New feature or request tcx_OpenForPickup labels Dec 14, 2020
@maxceem maxceem changed the title Update candidates status [$75] Update candidates status Dec 14, 2020
@maxceem maxceem added this to the v1.0 - Initial Launch milestone Dec 14, 2020
@maxceem
Copy link
Contributor Author

maxceem commented Dec 16, 2020

Contest https://www.topcoder.com/challenges/30158524 has been created for this ticket.

This is an automated message for maxceem via Topcoder X

@maxceem maxceem self-assigned this Dec 16, 2020
@maxceem
Copy link
Contributor Author

maxceem commented Dec 16, 2020

Contest https://www.topcoder.com/challenges/30158524 has been updated - maxceem has been unassigned.

This is an automated message for maxceem via Topcoder X

@maxceem maxceem removed their assignment Dec 16, 2020
@maxceem maxceem changed the title [$75] Update candidates status Update candidates status Dec 16, 2020
@maxceem maxceem self-assigned this Dec 16, 2020
maxceem added a commit that referenced this issue Dec 17, 2020
@maxceem
Copy link
Contributor Author

maxceem commented Dec 17, 2020

Done via 848668b. See demo video of the functionality https://monosnap.com/file/jl9Y66O87SNM88CUvTgw8gz28ErVGF

  • Added and configured Redux Store
  • Added and configured toastr, see how the popup looks like in the bottom left corner

image

@sandhiyakavi
Copy link
Collaborator

Verified.Working as expected.

issue.25.mp4

@SathyaJayabal
Copy link
Collaborator

Unable to update candidate status, getting an error "the user is not a member of project", even though the user is member of the connect project.
User: picachui
Project ID :26861
Screenshot 2021-01-28 at 7 20 03 PM
Screenshot 2021-01-28 at 7 20 27 PM

@wdprice
Copy link

wdprice commented Jan 28, 2021

The logged in user is a member of the Connect project or a Connect Manager role?

@SathyaJayabal could you open the project access controls in Connect?

@SathyaJayabal
Copy link
Collaborator

@wdprice , I can manage customer team, but only view topcoder team.
User Roles:
"Topcoder User", "copilot", "Connect Copilot"
Screenshot 2021-01-28 at 8 19 32 PM

@maxceem
Copy link
Contributor Author

maxceem commented Feb 13, 2021

@SathyaJayabal could you please add me to this project maxceem or share the password for the user you've used for testing (in Slack). So I could check this out, as it should not happen.

@SathyaJayabal
Copy link
Collaborator

@maxceem , sent invitation to the project.

@maxceem
Copy link
Contributor Author

maxceem commented Feb 23, 2021

@SathyaJayabal I've tried it with my user whom you've invited maxceem but it worked good for me. Could you please, try one more time if you could still reproduce it?

@SathyaJayabal
Copy link
Collaborator

@maxceem , still have the same issue.
Screenshot 2021-02-23 at 10 16 38 PM

@SathyaJayabal
Copy link
Collaborator

@sandhiyakavi , please try with your handle.

@maxceem
Copy link
Contributor Author

maxceem commented Feb 23, 2021

@nkumar-topcoder could you please help us debug this on RPOD.

Can we check the log the TaaS API.
What is the log message before userId: 22778049 the user is not a member of project 26861?

There should be a message produced be this line:

localLogger.debug({ context: 'checkIsMemberOfProject', message: `the members of project ${projectId}: ${memberIdList}` })

I wonder what it returns.

@SathyaJayabal
Copy link
Collaborator

@maxceem , works fine now
Screenshot 2021-02-24 at 4 40 14 PM

@SathyaJayabal
Copy link
Collaborator

This was fixed with update to m2m token scope

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request QA Pass on Prod
Projects
None yet
Development

No branches or pull requests

4 participants