Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

RCRM Job candidate Rejected Status Integration loop #142

Closed
sandhiyakavi opened this issue Apr 8, 2021 · 4 comments
Closed

RCRM Job candidate Rejected Status Integration loop #142

sandhiyakavi opened this issue Apr 8, 2021 · 4 comments

Comments

@sandhiyakavi
Copy link
Collaborator

Inifinite loop scenario happening with the Zap: 5 PROD - JOBCANDIDATE Update All Status RCRM to TaaS and 4-PROD-JOBCANDIDATE-Status-to-Rcrm

@sandhiyakavi sandhiyakavi added the P1 label Apr 8, 2021
@maxceem
Copy link
Contributor

maxceem commented Apr 8, 2021

References:

Suggested fix:

As have been discussed on Slack we would add a new status topcoder-rejected to indicate that candidate has been rejected in RCRM.

@maxceem
Copy link
Contributor

maxceem commented Apr 9, 2021

We found out the root cause of looping and fixed it via topcoder-platform/taas-es-processor#33.

The general idea of the fix, we should not post to Zapier to update status, if status was not really updated. Added the next unit tests which verify this logic:

  • should post to Zapier if status is changed to “rejected”
  • should post to Zapier if status is changed to “shortlist”
  • should not post to Zapier if status was already “rejected” and updated to “rejected”
  • should not post to Zapier if status was already “shortlist” and updated to “shortlist”
  • should not post to Zapier if status is changed to “interview” or another one (not “rejected” or “shortlist”)
  • should not post to Zapier if status is changed to "topcoder-rejected" (not "rejected" or "shortlist")

Though it appears that there was a second part of issue:

  • when rejecting JC from RCRM we want the JC status to be Topcoder Rejected (topcoder-rejected)
  • while when rejecting JS from TaaS we want the JS status to be Client Rejected (rejected)

For this purpose, we added support for a new status topcoder-rejected to Job Candidates.

DEV PRs

PROD PRs

@maxceem maxceem added this to the v1.5.3.1 Hotfix milestone Apr 9, 2021
@SathyaJayabal
Copy link
Collaborator

Verified the status updates between RCRM and TaaS App after the addition of the new status. The syncing of the statuses between the apps is working fine on Dev.

@SathyaJayabal
Copy link
Collaborator

Verified the status updates between RCRM and TaaS App after the addition of the new status. The syncing of the statuses between the apps is working fine on Prod.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants