Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$25] Disable Job Edit form when status is "assigned", "cancelled" or "closed" #138

Closed
maxceem opened this issue Mar 9, 2021 · 17 comments
Closed

Comments

@maxceem
Copy link
Contributor

maxceem commented Mar 9, 2021

If job status is "assigned", "cancelled" or "closed" we should disable on the field in the Job Edit form except of "status" (so we should be able to edit status).

Example job: https://platform.topcoder-dev.com/taas/myteams/16873/positions/edda7f39-5297-461a-89be-2074faa8bdc8/edit

image

@maxceem maxceem added this to the v1.5.1 - Post Release Bugfix milestone Mar 9, 2021
@maxceem maxceem changed the title Disable Job Edit form when status is "assigned", "cancelled" or "closed" [$25] Disable Job Edit form when status is "assigned", "cancelled" or "closed" Mar 9, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Mar 9, 2021

Challenge https://www.topcoder.com/challenges/13478285-8e2f-48f9-b473-f771091ed561 has been created for this ticket.

This is an automated message for maxceem via Topcoder X

@maxceem
Copy link
Contributor Author

maxceem commented Mar 9, 2021

@yoution this is ready for pickup.

@yoution
Copy link
Contributor

yoution commented Mar 9, 2021

@maxceem please assign to me

@maxceem
Copy link
Contributor Author

maxceem commented Mar 9, 2021

Challenge https://www.topcoder.com/challenges/13478285-8e2f-48f9-b473-f771091ed561 has been assigned to yoution.

This is an automated message for maxceem via Topcoder X

@yoution
Copy link
Contributor

yoution commented Mar 10, 2021

@maxceem I can not login
image

yoution added a commit to yoution/taas-app that referenced this issue Mar 10, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Mar 10, 2021

@yoution this is fixed on DEV now, please try again. By the way it works locally anyway.

@maxceem maxceem added this to the v1.5.3 - Post Release Bugfix milestone Mar 10, 2021
@yoution
Copy link
Contributor

yoution commented Mar 10, 2021

@maxceem still not work
image

@maxceem
Copy link
Contributor Author

maxceem commented Mar 10, 2021

got it, please pull the latests commit from dev branch.

or run the TaaS App like this APPENV=dev npm run dev

yoution added a commit to yoution/taas-app that referenced this issue Mar 10, 2021
@yoution
Copy link
Contributor

yoution commented Mar 10, 2021

@maxceem please review

@maxceem
Copy link
Contributor Author

maxceem commented Mar 10, 2021

@yoution could you please create a PR against this repository so I could review it.

@yoution
Copy link
Contributor

yoution commented Mar 10, 2021

@maxceem please reviewe #141

@maxceem maxceem added the enhancement New feature or request label Mar 11, 2021
yoution added a commit to yoution/taas-app that referenced this issue Mar 18, 2021
yoution added a commit to yoution/taas-app that referenced this issue Mar 18, 2021
maxceem added a commit that referenced this issue Mar 18, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
fix: issue #138
@maxceem
Copy link
Contributor Author

maxceem commented Mar 19, 2021

Payment failed: [400]: Failed to activate challenge. Detail: Cannot Activate this project, it has no active billing accounts.

This is an automated message for maxceem via Topcoder X

@sandhiyakavi
Copy link
Collaborator

@maxceem Can we have the border for all the fields (like before) when it is in non editable form. For the look and feel perspective. What do you think?

Before:
image

After
image

Other than that functionality wise , Everything is working as expected

  1. If status "Closed"
    image

  2. If status "Cancelled"
    image

  3. If status "Assigned"
    image

  4. If "isActiveApplication" field is true
    image

maxceem added a commit that referenced this issue Mar 22, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Mar 22, 2021

@sandhiyakavi added borders for the disabled fields:

image

@sandhiyakavi
Copy link
Collaborator

Thanks @maxceem

Verified on dev env.

image
image

@maxceem
Copy link
Contributor Author

maxceem commented Mar 23, 2021

Payment task has been updated: https://www.topcoder.com/challenges/13478285-8e2f-48f9-b473-f771091ed561
Payments Complete
Winner: yoution
Copilot: maxceem
Challenge 13478285-8e2f-48f9-b473-f771091ed561 has been paid and closed.

This is an automated message for maxceem via Topcoder X

@maxceem maxceem reopened this Mar 23, 2021
@sandhiyakavi
Copy link
Collaborator

sandhiyakavi commented Mar 29, 2021

Verified on Prod. Working as expected.

  1. Assigned status
    image

  2. Cancelled status
    image

  3. Closed status
    image

  4. Status is editable for Admin/Booking manager.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants