Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$15] Edit Jobs - Resource Type Field is text #120

Closed
wdprice opened this issue Feb 25, 2021 · 12 comments
Closed

[$15] Edit Jobs - Resource Type Field is text #120

wdprice opened this issue Feb 25, 2021 · 12 comments

Comments

@wdprice
Copy link

wdprice commented Feb 25, 2021

The Resource Type field is a text input, however that should be a drop down with same values displayed on the intake form:

image

image

@wdprice wdprice added bug Something isn't working P3 labels Feb 25, 2021
@wdprice wdprice added this to the v1.51 - Post Release Bugfix milestone Feb 25, 2021
@maxceem
Copy link
Contributor

maxceem commented Feb 25, 2021

@maxceem
Copy link
Contributor

maxceem commented Feb 25, 2021

Sum up:

  • add only 4 options

        { value: 'designer', title: 'Designer'},
        { value: 'software-developer', title: 'Software Developer'},
        { value: 'data-scientist', title: 'Data Scientist'},
        { value: 'data-engineer', title: 'Data Engineer'},
    
    • DON'T add 'QA Tester' and 'QA Engineer'
  • This value is optional, so the dropdown list should have first empty option, same like Workload

    image

  • Note, that the values which we save to the server are different from the values which we show to the user inside the dropdown options.

  • Follow how we implemented it for other dropdowns on the job edit/create page.

@maxceem maxceem changed the title Edit Jobs - Resource Type Field is text [$15] Edit Jobs - Resource Type Field is text Feb 25, 2021
@maxceem
Copy link
Contributor

maxceem commented Feb 25, 2021

Challenge https://www.topcoder.com/challenges/515b690c-7e2c-42ea-9e00-421df868eb73 has been created for this ticket.

This is an automated message for maxceem via Topcoder X

@maxceem
Copy link
Contributor

maxceem commented Feb 25, 2021

@yoution this is open for pickup.

@yoution
Copy link
Contributor

yoution commented Feb 25, 2021

@maxceem please assign to me

yoution added a commit to yoution/taas-app that referenced this issue Feb 25, 2021
yoution added a commit to yoution/taas-app that referenced this issue Feb 25, 2021
@yoution
Copy link
Contributor

yoution commented Feb 26, 2021

@maxceem please review

@maxceem
Copy link
Contributor

maxceem commented Feb 26, 2021

Challenge https://www.topcoder.com/challenges/515b690c-7e2c-42ea-9e00-421df868eb73 has been assigned to yoution.

This is an automated message for maxceem via Topcoder X

yoution added a commit to yoution/taas-app that referenced this issue Mar 2, 2021
yoution added a commit to yoution/taas-app that referenced this issue Mar 2, 2021
yoution added a commit to yoution/taas-app that referenced this issue Mar 2, 2021
maxceem added a commit that referenced this issue Mar 3, 2021
@maxceem
Copy link
Contributor

maxceem commented Mar 3, 2021

QA guidelines:

@maxceem
Copy link
Contributor

maxceem commented Mar 3, 2021

Payment task has been updated: https://www.topcoder.com/challenges/515b690c-7e2c-42ea-9e00-421df868eb73
Payments Complete
Winner: yoution
Copilot: maxceem
Challenge 515b690c-7e2c-42ea-9e00-421df868eb73 has been paid and closed.

This is an automated message for maxceem via Topcoder X

@sandhiyakavi
Copy link
Collaborator

@maxceem The text in the Resource type field is shown as "Select..." instead of "Resource Type" .

resource type name is missing

Other than that everything is good.

  1. Four options are displayed correctly with blank space option.

four_options_displayed

  1. Correct resource type displayed in Job view page.

correct_resource type_displayed_view page

  1. Correct resource type displayed in Edit Job page.

Screenshot_4

  1. If no option selected.

if no resource type

  1. If incorrect resource type entered in old jobs and is editable

unsupported value_sD

![image](https://user-images.githubusercontent.com/55895538/109779931-d270d980-7c49-11eb-8304-663740028c93.png)

@maxceem
Copy link
Contributor

maxceem commented Mar 3, 2021

The text in the Resource type field is shown as "Select..." instead of "Resource Type" .

@sandhiyakavi nice catch, I've logged a separate issue for this #137. The same issue we have for all selects.

@sandhiyakavi
Copy link
Collaborator

Verified on Prod Env. Working as expected.

  1. Four options displayed in both View/Edit page.
    image

  2. Correct Resource type displayed in View/Edit page.
    image
    image

  3. Unavailable Resource type.
    image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants