Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Fixes for search handle field behavior. #41

Merged
merged 1 commit into from
Jun 19, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 43 additions & 30 deletions src/components/SearchHandleField/index.jsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useCallback, useState } from "react";
import React, { useCallback, useRef, useState } from "react";
import PT from "prop-types";
import cn from "classnames";
import throttle from "lodash/throttle";
Expand Down Expand Up @@ -93,57 +93,46 @@ const SearchHandleField = ({
const [isMenuOpen, setIsMenuOpen] = useState(false);
const [isMenuFocused, setIsMenuFocused] = useState(false);
const [options, setOptions] = useState([]);

const loadOptions = useCallback(
throttle(
async (value) => {
setIsLoading(true);
const options = await loadSuggestions(value);
setOptions(options);
setIsLoading(false);
setIsMenuOpen(true);
setIsMenuFocused(options.length && options[0].value === value);
},
300,
{ leading: false }
),
[]
);
const isChangeAppliedRef = useRef(false);

const onValueChange = (option, { action }) => {
if (action === "input-change" || action === "select-option") {
setIsMenuFocused(false);
setIsMenuOpen(false);
if (!isMenuFocused) {
onChange(inputValue);
} else if (option) {
if (isMenuFocused && !isLoading && option) {
isChangeAppliedRef.current = true;
setIsMenuFocused(false);
setIsMenuOpen(false);
setIsLoading(false);
onChange(option.value);
}
} else if (action === "clear") {
isChangeAppliedRef.current = true;
setIsMenuFocused(false);
setIsMenuOpen(false);
setIsLoading(false);
onChange("");
}
};

const onInputValueChange = useCallback(
(value, { action }) => {
if (action === "input-change") {
isChangeAppliedRef.current = false;
setIsMenuFocused(false);
setInputValue(value);
onInputChange && onInputChange(value);
loadOptions(value);
}
},
[onInputChange, loadOptions]
[onInputChange]
);

const onKeyDown = (event) => {
const key = event.key;
if (key === "Enter" || key === "Escape") {
setIsMenuFocused(false);
setIsMenuOpen(false);
if (!isMenuFocused) {
if (!isMenuFocused || isLoading) {
isChangeAppliedRef.current = true;
setIsMenuFocused(false);
setIsMenuOpen(false);
setIsLoading(false);
onChange(inputValue);
}
} else if (key === "ArrowDown") {
Expand All @@ -160,16 +149,40 @@ const SearchHandleField = ({
}
};

const onSelectBlur = useCallback(() => {
const onSelectBlur = () => {
setIsMenuFocused(false);
setIsMenuOpen(false);
onChange(inputValue);
onBlur && onBlur();
}, [onBlur]);
};

const loadOptions = useCallback(
throttle(
async (value) => {
if (!isChangeAppliedRef.current) {
setIsLoading(true);
const options = await loadSuggestions(value);
if (!isChangeAppliedRef.current) {
setOptions(options);
setIsLoading(false);
setIsMenuOpen(true);
}
}
},
300,
{ leading: false }
),
[]
);

useUpdateEffect(() => {
setInputValue(value);
}, [value]);

useUpdateEffect(() => {
loadOptions(inputValue);
}, [inputValue]);

return (
<div
className={cn(
Expand Down Expand Up @@ -214,7 +227,7 @@ const loadSuggestions = async (inputValue) => {
}
try {
const res = await getMemberSuggestions(inputValue);
const users = res.data.result.content;
const users = res.data.result.content.slice(0, 100);
let match = null;
for (let i = 0, len = users.length; i < len; i++) {
let value = users[i].handle;
Expand Down