Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$30] Don't allow processing payments for the future WorkPeriods #73

Closed
maxceem opened this issue Jul 19, 2021 · 13 comments
Closed

[$30] Don't allow processing payments for the future WorkPeriods #73

maxceem opened this issue Jul 19, 2021 · 13 comments

Comments

@maxceem
Copy link
Contributor

maxceem commented Jul 19, 2021

At the moment we process payment for any WorkPeriod no matter if it's already past, current of future. We should NOT only allow processing/creating payments for future WorkPeriods.

  • If we select WorkPeriod which is in the future - disable all the checkboxes and "Proces Payment" button so we cannot process a payment.
  • when we put the cursor on the disabled checkbox or disabled "Process Payment" button show a tooltip saying: "Can only process payment for the past week". Reuse existent component for Tooltips.
@maxceem maxceem changed the title Only allow processing payments for the past WorkPeriods [$20] Only allow processing payments for the past WorkPeriods Jul 19, 2021
@maxceem maxceem added the CF Issues for Community Fixes label Jul 19, 2021
@maxceem maxceem added this to the v1.0.3 - UAT Feedback milestone Jul 19, 2021
@maxceem maxceem changed the title [$20] Only allow processing payments for the past WorkPeriods [$30] Only allow processing payments for the past WorkPeriods Jul 19, 2021
@yoution
Copy link
Contributor

yoution commented Jul 20, 2021

@maxceem please assign to me

@maxceem
Copy link
Contributor Author

maxceem commented Jul 20, 2021

@yoution we've got a small update for this task, we should also allow processing payments for the current week.
So we should only not allow processing payments for the future weeks. I've update the task description.

@maxceem maxceem changed the title [$30] Only allow processing payments for the past WorkPeriods [$30] Don't allow processing payments for the future WorkPeriods Jul 20, 2021
yoution pushed a commit to yoution/micro-frontends-taas-admin-app that referenced this issue Jul 21, 2021
yoution added a commit to yoution/micro-frontends-taas-admin-app that referenced this issue Jul 21, 2021
maxceem added a commit that referenced this issue Jul 21, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Jul 21, 2021

Challenge https://www.topcoder.com/challenges/08c5a1ef-02ab-481e-9fda-36e0da2ee5d6 has been created for this ticket.

This is an automated message for maxceem via Topcoder X

@maxceem
Copy link
Contributor Author

maxceem commented Jul 21, 2021

Challenge https://www.topcoder.com/challenges/08c5a1ef-02ab-481e-9fda-36e0da2ee5d6 has been assigned to yoution.

This is an automated message for maxceem via Topcoder X

@maxceem
Copy link
Contributor Author

maxceem commented Jul 21, 2021

Challenge https://www.topcoder.com/challenges/1edf868e-9629-4f7d-8edd-576f6a57b457 has been created for this ticket.

This is an automated message for maxceem via Topcoder X

@maxceem
Copy link
Contributor Author

maxceem commented Jul 21, 2021

Challenge https://www.topcoder.com/challenges/1edf868e-9629-4f7d-8edd-576f6a57b457 has been assigned to yoution.

This is an automated message for maxceem via Topcoder X

@maxceem
Copy link
Contributor Author

maxceem commented Jul 21, 2021

Challenge https://www.topcoder.com/challenges/1edf868e-9629-4f7d-8edd-576f6a57b457 yoution has been unassigned.

This is an automated message for maxceem via Topcoder X

@maxceem maxceem assigned yoution and unassigned yoution Jul 21, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Jul 21, 2021

Challenge https://www.topcoder.com/challenges/1edf868e-9629-4f7d-8edd-576f6a57b457 yoution has been unassigned.

This is an automated message for maxceem via Topcoder X

@maxceem
Copy link
Contributor Author

maxceem commented Jul 21, 2021

yoution has been unassigned because this ticket doesn't have the tcx_OpenForPickup label.

This is an automated message for maxceem via Topcoder X

@maxceem
Copy link
Contributor Author

maxceem commented Jul 21, 2021

Challenge https://www.topcoder.com/challenges/1edf868e-9629-4f7d-8edd-576f6a57b457 has been assigned to yoution.

This is an automated message for maxceem via Topcoder X

@sandhiyakavi
Copy link
Collaborator

sandhiyakavi commented Jul 22, 2021

Verified on Dev Env.

The checkboxes are enabled only for past and current weeks and disabled for all future weeks with the tool tip message

image

image

@maxceem
Copy link
Contributor Author

maxceem commented Jul 22, 2021

Payment task has been updated: https://www.topcoder.com/challenges/1edf868e-9629-4f7d-8edd-576f6a57b457
Payments Complete
Winner: yoution
Copilot: maxceem
Challenge 1edf868e-9629-4f7d-8edd-576f6a57b457 has been paid and closed.

This is an automated message for maxceem via Topcoder X

@maxceem maxceem reopened this Jul 22, 2021
@lakshmiathreya
Copy link

Verified in Prod.
Screenshot 2021-07-30 at 1 26 19 PM
Screenshot 2021-07-30 at 1 27 52 PM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants