Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$50] Filter by Alerts #72

Closed
maxceem opened this issue Jul 19, 2021 · 15 comments
Closed

[$50] Filter by Alerts #72

maxceem opened this issue Jul 19, 2021 · 15 comments

Comments

@maxceem
Copy link
Contributor

maxceem commented Jul 19, 2021

Support filtering by Alerts column.

On the left sidebar add a new section called Alerts with the next 3 checkboxes to filter by:

  • No BA Assigned
  • OnBoarding Week
  • Last Booking Week

It should look like this:

image

API

@maxceem maxceem added this to the v1.0.3 - UAT Feedback milestone Jul 19, 2021
@maxceem maxceem added Blocked CF Issues for Community Fixes labels Jul 19, 2021
@maxceem maxceem changed the title Filter by Alerts [$20] Filter by Alerts Jul 19, 2021
@maxceem maxceem removed the Blocked label Jul 20, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Jul 20, 2021

@yoution the API for this task is implemented now, so feel free to pick this up.

@yoution
Copy link
Contributor

yoution commented Jul 21, 2021

@maxceem please assign to me

@yoution
Copy link
Contributor

yoution commented Jul 21, 2021

@maxceem I don't know how to pass the parameters to the BE,
for alert filter, we can only select one option at the same time? or we can select all like payment status ?
for no db assign, if checked, we pass billingAccountId:0, if unchecked? what to pass?
for onboarding week, if checked, we pass isFirstWeek=true, if unchecked, we pass isFirstWeek=false? and last booking week also do like so?

@maxceem
Copy link
Contributor Author

maxceem commented Jul 21, 2021

@yoution good questions.

for no db assign, if checked, we pass billingAccountId:0, if unchecked? what to pass?

if unchecked, then don't pass filter by billingAccountId at all

for onboarding week, if checked, we pass isFirstWeek=true, if unchecked, we pass isFirstWeek=false? and last booking week also do like so?

if uncheck, better don't pass anything, but passing false is also fine.

for alert filter, we can only select one option at the same time? or we can select all like payment status ?

Hmm, I have to clarify this moment. I would be back to you shortly. For now, I guess you can allow to select them all like for payments.

@yoution
Copy link
Contributor

yoution commented Jul 21, 2021

because I found if I pass isFirstWeek and isLastWeek together, the BE will show error, so I asked to you.
on the other hand, this payment seems a little low, the url must update, when I check the checkbox, how about 50$?

@maxceem
Copy link
Contributor Author

maxceem commented Jul 21, 2021

because I found if I pass isFirstWeek and isLastWeek together,

yeah, we would fix it in API, please ignore this error for now, it would go away soon.

on the other hand, this payment seems a little low, the url must update, when I check the checkbox, how about 50$?

ok, updated to $50

@maxceem maxceem changed the title [$20] Filter by Alerts [$50] Filter by Alerts Jul 21, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Jul 21, 2021

because I found if I pass isFirstWeek and isLastWeek together,

API should allow passing both together now

yoution added a commit to yoution/micro-frontends-taas-admin-app that referenced this issue Jul 21, 2021
@yoution
Copy link
Contributor

yoution commented Jul 21, 2021

  1. seems still not work
    image
    image
  2. for ba id
    image
    image

@maxceem
Copy link
Contributor Author

maxceem commented Jul 21, 2021

  1. workPeriods.isFirstWeek and workPeriods.isLastWeek are not allowed inside the fields param, because we don't have such fields. We can only use them as filters.

  2. hmm, I'll check this out

@maxceem
Copy link
Contributor Author

maxceem commented Jul 21, 2021

@yoution regrading the second issue with BA. It happens because &billingAccountId=0 is included twice inside the request which is converted to array in the API side. &billingAccountId=0 should be included only once in URL.

yoution added a commit to yoution/micro-frontends-taas-admin-app that referenced this issue Jul 21, 2021
maxceem added a commit that referenced this issue Jul 21, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Jul 21, 2021

Challenge https://www.topcoder.com/challenges/e873575e-b876-4f19-a499-17262a0c76cc has been created for this ticket.

This is an automated message for maxceem via Topcoder X

@maxceem
Copy link
Contributor Author

maxceem commented Jul 21, 2021

Challenge https://www.topcoder.com/challenges/e873575e-b876-4f19-a499-17262a0c76cc has been assigned to yoution.

This is an automated message for maxceem via Topcoder X

@maxceem
Copy link
Contributor Author

maxceem commented Jul 22, 2021

Payment task has been updated: https://www.topcoder.com/challenges/e873575e-b876-4f19-a499-17262a0c76cc
Payments Complete
Winner: yoution
Copilot: maxceem
Challenge e873575e-b876-4f19-a499-17262a0c76cc has been paid and closed.

This is an automated message for maxceem via Topcoder X

@maxceem maxceem reopened this Jul 22, 2021
@sandhiyakavi
Copy link
Collaborator

sandhiyakavi commented Jul 22, 2021

Verified in Dev Env.

  1. If all Alert options selected, only resource that satisfies all options is displayed
    image

  2. If 'Last Booking Week' selected, only resources with last booking week is displayed,
    image

  3. If 'No BA assigned' selected, only resources for which BA not assigned are displayed,
    image

  4. No resource booking found displayed if no resource booking satisfies the options.
    image

@lakshmiathreya
Copy link

Filter by Alerts Verified in Prod.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants