Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$5] Messages for single resource are in plural form. #46

Closed
sandhiyakavi opened this issue Jun 23, 2021 · 8 comments
Closed

[$5] Messages for single resource are in plural form. #46

sandhiyakavi opened this issue Jun 23, 2021 · 8 comments

Comments

@sandhiyakavi
Copy link
Collaborator

Description:

The messages displayed in Taas Admin app are all in plural form. Can we display the Message like below? so that it would be common for both singular as well as plural content.

sample: "Payment in progress for 1 resource(s)"

plural_problemn

@maxceem
Copy link
Contributor

maxceem commented Jun 30, 2021

Sum up:

  • Copy/paste the helper method formatPlural to this repository.
  • Apply it in the messages:
    • when process 1 or several payments on one page
    • when process payments for ALL records

@maxceem maxceem added the CF Issues for Community Fixes label Jun 30, 2021
@maxceem maxceem changed the title Messages for single resource are in plural form. [$5] Messages for single resource are in plural form. Jun 30, 2021
@sandhiyakavi
Copy link
Collaborator Author

@maxceem If we check select all and only one record is available then in that case it is still displaying in plural form.

image

Other than above, others are displaying fine.
image
image

@maxceem
Copy link
Contributor

maxceem commented Jul 5, 2021

@sandhiyakavi fixed plural form when selecting.

@sandhiyakavi
Copy link
Collaborator Author

@maxceem Still it is denoting plural '1 record on this page are selected'

still_denoting_plural

maxceem added a commit that referenced this issue Jul 6, 2021
@maxceem
Copy link
Contributor

maxceem commented Jul 6, 2021

@sandhiyakavi is / are fixed now.

@sandhiyakavi
Copy link
Collaborator Author

Verified on Dev Env.

image
image
image
image

@maxceem
Copy link
Contributor

maxceem commented Jul 7, 2021

@maxceem maxceem added the PAID label Jul 7, 2021
@sandhiyakavi
Copy link
Collaborator Author

verified on Prod Env with @nkumar-topcoder

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants