fix for issue taas-apis/issues/477 #30
Conversation
There was a problem hiding this comment.
@nqviet at the moment there is a special code added for plural text textIsPlural specially for one notification type: https://github.com/topcoder-platform/micro-frontends-navbar-app/pull/30/files#diff-3a94f8910b31b990d77495d72abc950ee1836a0f0fa72a467bba78dddc2efd14R582-R591
Instead of this, could we just use handlebars for this? For example see several examples here handlebars-lang/handlebars.js#249.
We would need to create a helper for plural words here https://github.com/topcoder-platform/micro-frontends-navbar-app/blob/dev/src/utils/notifications.js#L63-L64 using one of the examples from handlebars-lang/handlebars.js#249.
Other than this everything works great.
|
@maxceem The PR is ready |
No description provided.