Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Member Didn't Agree to Challenge Terms #19

Closed
rootelement opened this issue Sep 5, 2018 · 2 comments
Closed

Member Didn't Agree to Challenge Terms #19

rootelement opened this issue Sep 5, 2018 · 2 comments
Assignees

Comments

@rootelement
Copy link

I'm paying out users for a completed Marathon Match. Apparently the terms they agree to are different than those that direct needs for challenges.

I've submitted a payment for user now_you_see, who has not agreed to terms. The payment tool just hangs on "Drafting Payment" and never comes back. The challenge is created in direct, but the member is not assigned (obviously) so it's just frozen.

Adding the user in direct shows this error:
screen shot 2018-09-05 at 1 54 55 pm

The UI should, on this error, come back and say the error to the user, not just hang out there.

@cwdcwd
Copy link
Contributor

cwdcwd commented Sep 5, 2018

So I'm not sure if the API gives back the error details to handle verbosely but the App should not just hang out like it does when there's an error. We need some graceful error handling put in around this and #16. I think the latter case is a known issue with the challenge API creating and activating a challenge but, again, we should field any API error responses or timeouts appropriately.
@birdofpreyru thoughts?

birdofpreyru added a commit that referenced this issue Sep 6, 2018
@birdofpreyru
Copy link
Collaborator

@cwdcwd yeah, it turns out that the error-messaging setup of community-app was not correctly reproduced in topcoder-payment-tool when it was spawned out, so error messages were not shown in UI. I fixed this and released to development environment. Though, at the moment it does not tell about precise errors, just shows the modal saying smth like It did not work out, please finalize via Direct, or contact Topcoder support. By the way, develop contains a bunch of other updates that were never put to production.

@cwdcwd cwdcwd closed this as completed Oct 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants