This repository was archived by the owner on Jan 23, 2025. It is now read-only.
load project groups to DW #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RishiRajSahu
suggested changes
Jun 26, 2019
There was a problem hiding this comment.
@gondzo overall looks good to me, just few points to consider before merging, please address them.
ajefts
reviewed
Jun 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merging, a new table should be created in DW:tcs_dw
create table project_groups (project_id DECIMAL(12,0), group_id DECIMAL(12,0), PRIMARY KEY (project_id, group_id) CONSTRAINT project_group_pkey);