This repository was archived by the owner on Jan 23, 2025. It is now read-only.
Change getTimestamp to use internal date #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyhit
reviewed
Jun 1, 2018
| @@ -38,7 +38,7 @@ | |||
| * @version 1.0 | |||
| * | |||
| */ | |||
| @DelayStart("20s") | |||
| @DelayStart("19s") | |||
There was a problem hiding this comment.
@deedee any reason to change this?
There was a problem hiding this comment.
If all jobs start on same time ConcurrentModificationException sometime occur on getMatchesWithRegistrationPhaseStartedIds or getChangedChallengeIds
There was a problem hiding this comment.
@deedee it is from dropwizard framework?
There was a problem hiding this comment.
not sure, that exception came from jdbi while mapping the result. I'm still looking at the cause, seems related to job execution. This change eliminate startup issue.
skyhit
reviewed
Jun 1, 2018
| @@ -117,8 +117,7 @@ public void doJob(JobExecutionContext context) throws JobExecutionException { | |||
|
|
|||
| logger.info("The last run timestamp for challenges listing job is:" + timestamp); | |||
|
|
|||
| String currentTime = DATE_FORMAT.format(this.challengeListingFeederManager.getTimestamp()); | |||
|
|
|||
| String currentTime = DATE_FORMAT.format(new Date()); | |||
There was a problem hiding this comment.
@deedee why this is special?
There was a problem hiding this comment.
because it just simply use system date?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.