This repository was archived by the owner on Mar 4, 2025. It is now read-only.
PR for issue_905 -iversonLv- another solution: hide X button and click overl… #935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay to cclose the badge modal dialog
|
@iversonLv Is this what we should instead of the previous PR? Or do I need to pull in both for this to work? Thanks. |
|
@ajefts Wait a sec, I'm writing a response in the original issue |
|
This one seems to not work anyway. |
|
I.e. it closes the modal by pressing Esc on the keyboard, but does not close on mouse clicks outside the content. |
|
Forgot this one, I merge some herku testing file. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ay to cclose the badge modal dialog
PR for issue #905