This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Implemented new designs for invite-only and private challenge cards #726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nges shown on Profile SUP-3012, [Profile] Implement "private challenge" card -- Implemented new design (background, text and font) for both invite-only and private challenge cards in tile and list views
vikasrohit
pushed a commit
that referenced
this pull request
Feb 10, 2016
…y-challenge-card Implemented new designs for invite-only and private challenge cards
| img(ng-src=require("../../../assets/images/ico-invite-only-prj.svg")) | ||
| span INVITE-ONLY CHALLENGE | ||
| span CHALLENGE INFORMATION IS CONFIDENTIAL#[br]RESULTS ARE NOT INCLUDED IN STATISTICS |
There was a problem hiding this comment.
I know it's a little bit of a hassle, but I think semantically <br> shouldn't be used here. Two <p> tags might be able to work in its place? Not totally crucial to change though 
There was a problem hiding this comment.
Thanks Nick for the review. I also thought of that, however, using
does not seems good solution to me because many times p's margin/padding creates differences in rendering for different browsers. I would try to use two divs instead whenever I get chance to revisit this. 😁
There was a problem hiding this comment.
Do the browsers render them differently even with our CSS reset?
There was a problem hiding this comment.
Ideally they should not after CSS reset, but I don't trust them. :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUP-2839, Profile: # of wins in summary does not match winning challenges shown on Profile
SUP-3012, [Profile] Implement "private challenge" card
-- Implemented new design (background, text and font) for both invite-only and private challenge cards in tile and list views
@fnisen @vic-appirio @nlitwin Please let me know if anything is out of standards.