This repository was archived by the owner on Mar 4, 2025. It is now read-only.
SUP-3055, [Edit Profile] Can't delete weblink in profile #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 9, 2016 16:11
-- Fixed. Added content type header in the request.
-- Fixed lint errors
|
I think most services default to application/json and that's how this was probably working. Explicitly adding it is better though. |
parthshah
added a commit
that referenced
this pull request
Feb 10, 2016
…eblink-remove SUP-3055, [Edit Profile] Can't delete weblink in profile
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Fixed. Added content type header in the request.
@parthshah @nlitwin I am not sure how it was working earlier. I have checked logs for the api.service.js but not able to find any evidence of removing the content headers from it. Please let me know if you see any problems with setting content type to json for all requests.