This repository was archived by the owner on Mar 4, 2025. It is now read-only.
SUP-3058, Adapt FE according to new json structure of challenge endpoint #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 9, 2016 15:03
-- Adapted the code to use winningPlacements array for determining the placement of member for any kind of challenge -- Updated unit tests -- Used submission statuses for determining the user status for passing the review for one of the submissions
-- Fixed lint errors
…ion range -- Fixed showing placement outside of the winning placement boundaries and shown 'Passed Review' instead of placement for such challenges.
-- Fixed. Added content type header in the request.
This reverts commit b77587e.
| @@ -702,7 +725,7 @@ describe('Challenge Service', function() { | |||
| ] | |||
| ChallengeService.processPastChallenges(challenges) | |||
| var challenge = challenges[0] | |||
| expect(challenge.highestPlacement).to.exist.to.equal(5) | |||
| expect(challenge.highestPlacement).not.to.exist.to | |||
There was a problem hiding this comment.
Not sure if the dangling .to is messing anything up or giving a false test pass, but it can be deleted :)
There was a problem hiding this comment.
Thanks Nick!! Fixed it. And I think it was not causing the false test pass. 😁
|
lgtm! |
-- Minor change for unit tests
vikasrohit
pushed a commit
that referenced
this pull request
Feb 10, 2016
…or-json-change-challenges-api SUP-3058, Adapt FE according to new json structure of challenge endpoint
vikasrohit
deleted the
feature/sup-3058-adapt-fe-for-json-change-challenges-api
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@parthshah @nlitwin please let me know if I have missed anything here.
-- Adapted the code to use winningPlacements array for determining the placement of member for any kind of challenge
-- Updated unit tests
-- Used submission statuses for determining the user status for passing the review for one of the submissions