This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Feature/sup 2839 invite only challenge card #720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 8, 2016 15:29
…nges shown on Profile SUP-3012, [Profile] Implement "private challenge" card -- Fixed issue with rendering of fallback-src directive for "No image available" placeholder image. -- Hidden the placement(for both dev and design) and submission images (for design) view for invite-only challenges. -- Changed the placeholder image for private challenges where submissions are not viewable. As of now API does not support that, hence, negation of isPrivate field is used to determine submissionViewable or not.
* dev: (23 commits) Delete unneeded folder and files Add better examples Update command in readme Change command Update readme for linting Enforce linting and fail early with travis scripts Try travis command Try different error and travis command test lint error Enforce linting Remove unused code Update version Too many semicolons Put back after fix Test Refactor for clarification and remove unneeded code Add detect encoding to production Move mangle options outside webpack config repo Put back webpack version for new release Remove old karma browsers ...
-- Removed jslint error
vikasrohit
pushed a commit
that referenced
this pull request
Feb 8, 2016
…y-challenge-card Feature/sup 2839 invite only challenge card @nlitwin @vic-appirio @parthshah merging to show it in working on dev environment. cc: @fnisen
| img(ng-show="!challenge.isPrivate", ng-src="{{imageURL || require('../../../assets/images/card-bg-no-image.svg')}}", fallback-src=require("../../../assets/images/card-bg-no-image.svg")) | ||
| img(ng-show="challenge.isPrivate", src=require("../../../assets/images/card-bg-private-project.svg")) | ||
| img(ng-show="challenge.submissionViewable && imageURL", ng-src="{{imageURL}}") | ||
| img(ng-show="challenge.submissionViewable && !imageURL", ng-src="../../../assets/images/card-bg-no-image.svg") |
There was a problem hiding this comment.
We should add require statement here, so Webpack can handle the dependency on the image
There was a problem hiding this comment.
Thanks for catching it. :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@parthshah @nlitwin @vic-appirio Please let me know if you guys think it is not done in desired way.