Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

SUP-2994, My Challenges | | Empty page when loading past challenges #665

Merged
merged 1 commit into from
Jan 19, 2016
Merged

SUP-2994, My Challenges | | Empty page when loading past challenges #665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/services/challenge.service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,8 @@
return submission.type === CONSTANTS.SUBMISSION_TYPE_CONTEST && submission.placement;
}), 'placement').placement;
}
if (challenge.track === 'DEVELOP' && challenge.subTrack === 'FIRST_2_FINISH') {
if (challenge.track === 'DEVELOP' && challenge.subTrack === 'FIRST_2_FINISH'
&& challenge.userDetails.submissions && challenge.userDetails.submissions.length > 0) {
challenge.highestPlacement = _.min(challenge.userDetails.submissions.filter(function(submission) {
return submission.type === CONSTANTS.SUBMISSION_TYPE_CONTEST
&& submission.status === CONSTANTS.STATUS_ACTIVE && submission.placement;
Expand Down
24 changes: 23 additions & 1 deletion app/services/challenge.service.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ describe('Challenge Service', function() {
expect(challenge.userHasSubmitterRole).to.exist.to.true;
});

it('processPastChallenges should process a not completed DEVELOP/FIRST_2_FINISH challenge ', function() {
it('processPastChallenges should process a not completed (empty submissions) DEVELOP/FIRST_2_FINISH challenge ', function() {
var challenges = [
{
id: 30041345,
Expand All @@ -348,6 +348,28 @@ describe('Challenge Service', function() {
expect(challenge.userHasSubmitterRole).to.exist.to.true;
});

it('processPastChallenges should process a not completed(null submissions) DEVELOP/FIRST_2_FINISH challenge ', function() {
var challenges = [
{
id: 30041345,
name: 'Mock Challenge 1',
track: 'DEVELOP',
subTrack: 'FIRST_2_FINISH',
userDetails: {
hasUserSubmittedForReview: false,
roles: ['Submitter'],
submissions: null
}
}
];
ChallengeService.processPastChallenges(challenges);
var challenge = challenges[0];
expect(challenge.highestPlacement).not.to.exist;
expect(challenge.wonFirst).to.exist.to.false;
expect(challenge.userStatus).to.exist.to.equal('NOT_FINISHED');
expect(challenge.userHasSubmitterRole).to.exist.to.true;
});

it('processPastChallenges should process a DEVELOP/FIRST_2_FINISH challenge for a non submitter user ', function() {
var challenges = [
{
Expand Down