SUP-2930, Register--> 'Create Password' text fileld showing one line at beginning.

[vikasrohit]

@vic-appirio @nlitwin please let me know if you guys find any thing inappropriate here.

@vic-appirio I have seen in git history that you have made some changes (21cf847, 190ab97) to toggle password input styles about a month back. I am afraid if I have broken those changes. Please review my changes and please try it once on your local. It would really help me to be sure about the changes.

-- Fixed style of toggle with password directive to have smooth inner input box.

[vic-tian]

Nick took over the style in general. @nlitwin can you verify if everything is fine?

[vikasrohit]

@nlitwin do you know if we need to override toggle-password and toggle-password-with-tips styles in https://github.com/appirio-tech/styles/blob/master/styles/topcoder/_tc-forms.scss? Can we remove that from styles repo?

[vikasrohit]

@nlitwin I have pushed changes for SUP-2970 as well in this PR because these two are closely related.

[nlitwin]

It looks like to me that we have CSS being applied to the toggle-password directives in the style guide (_tc-forms.scss) and locally (directives/toggle-password.scss), right? I think since this is a reusable component, we could move the local styles to the style guide. I've been adding new style guide updates to the branch "panels", until we move to webpack. Not sure if that answers your question.. haha :) Let me know if it doesn't!

[vikasrohit]

Right now I have managed to fix it with changes in topcoder-app. May be we can move complete styles of toggle-password and toggle-password-with-tips to the styles repo later. Or let me know if you want me to move it to there now.

Merging the branch for now considering the v1.0.20 release tomorrow.