This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Feature/sup 1159 upload progress bar #646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 6, 2016 18:14
-- Added event handler for progress notification of upload -- Added progress aggregator for multiple file upload progress -- Showed, for POC, the progress bar with text message on the same page with custom directive
-- Implemented approved designs for normal and error states (action buttons for error states are pending)
-- Reverted the change to test error condition -- Added more error handlers
-- Added functionality to Try Again button in case of error.
* dev: Add outstanding error and css updates Add disabled ability to tc-input Copy update Add validation and error messages for fonts section Refactor fonts section to have its own directive and controller Add container directive for fonts Add url for help link on mobile Make error messages correct width updated some icons Add proper phaseTypes Add back link for devices page Add label and width to font dropdown and width to rank input Conflicts: app/submissions/submit-file/submit-file.controller.js assets/css/submissions/submit-file.scss
-- Fixing unit tests error.
| @@ -40,7 +40,7 @@ | |||
| "angular-xml": "~2.1.1", | |||
| "angularjs-toaster": "~0.4.15", | |||
| "appirio-tech-ng-iso-constants": "[email protected]:appirio-tech/ng-iso-constants#~1.0.5", | |||
| "appirio-tech-ng-ui-components": "1.x.x", | |||
| "appirio-tech-ng-ui-components": "appirio-tech/ng-ui-components#bower-wiredep-fix", | |||
There was a problem hiding this comment.
@parthshah @nlitwin This is a temporary change. Ideally, we should get that branch published as a new tag. I would remove this change once the branch in ng-ui-components is published.
|
Looks awesome! :D :D |
nlitwin
added a commit
that referenced
this pull request
Jan 8, 2016
…gress-bar Feature/sup 1159 upload progress bar
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@parthshah @nlitwin Please let me know if you anything that is wrong or can be improved.
Most of the functionality is implemented, with following remaining points from top of my head:
-- Unit tests (I didn't find any existing test for upload feature, hence I couldn't piggy back those unit test for verifying the progress bar. Further, I am still trying to find a way to test a private method of a controller without exposing it on the controller object)
-- Redirection to appropriate pages in case of successful upload or user decides to cancel the upload in case of error
-- Cancel the submission upload operation when user clicks on x icon in top right of the modal popup. I didn't implement it because I guess the button is not there in the design. I am using modal component from ng-ui-components which has a cross button. Should we remove the option of closing the popup or ask user before closing in a confirmation box?
-- Replacing challenge name placeholder for both error and no error condition of update progress UI.
I am creating PR with these pending items, so that while @nlitwin is developing the core functionality of the requirement, he can also test out the progress bar and further, to make sure that our code changes are in sync. Please let me know if you guys have any concerns.
NOTE: Please do a bower install before testing this PR.