This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Feature/sup 2910 misc skill picker issues #630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 28, 2015 17:32
-- Fixed - The iOS community component seems to be different from the tracks components (e.g., Design). The tracks components all have a grey background that turns white when the pill is switched. The iOS community component should behave exactly the same.
-- Fixed - The "Done" button should not activate if only the iOS community is selected. The user must also select a track. (The iOS community is additional to the tracks; it's not a track itself)
-- Fixed - Icons for several Data Science skills appear broken
-- Fixed - Change the wording at the top to say "select the communities and tracks in which..."
|
lgtm |
-- Updated the instructions text to be generic.
|
Updated the text to be generic as per comment. |
|
Thanks @nlitwin for the review. |
vikasrohit
pushed a commit
that referenced
this pull request
Dec 30, 2015
…-picker-issues Feature/sup 2910 misc skill picker issues
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nlitwin @tladendo @parthshah Please let me know if you guys find anything out of standard.
Fixed mentioned issues with skill-picker. With following exceptions: