This repository was archived by the owner on Mar 4, 2025. It is now read-only.
added links #622
Merged
added links #622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .ended-on #[span {{srm.codingEndAt | localTime:"MMM DD, YYYY" }}] | ||
|
|
||
| .member-stats | ||
| p.points #[span {{srm.result.finalPoints }}] #[span Points] | ||
| .ranks | ||
| .division | ||
| a.division(href="https://community.{{DOMAIN}}/stat?c=round_stats&rd={{srm.rounds[0].id}}&dn={{srm.result.division}}") |
There was a problem hiding this comment.
Do SRMs always have at least one round with an id and a result property with a division property? If not, we may want to handle the logic for this link in the controller that owns this HTML and pass a single, determined value to the link like srm.roundId. But it may be unnecessary if the API always returns those values :)
|
@tladendo I think we are missing the division and room links in list view of the srm-tile. |
tladendo
added a commit
that referenced
this pull request
Dec 23, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fyi @parthshah @nlitwin @vikasrohit