SUP-2728, Add iOS community to Onboarding page (Skill picker) #613
Conversation
-- Added communities section -- Communities section will be visible only if there exists at least one community for which the member is not registered yet -- Added unit tests
|
@nlitwin @tladendo Can one of you guys please checkout the branch on your local and check the appearance of the "Done" button when you disable the switch button after enabling once? For me, it is disabling the button, however, the button is not taking the appearance of a disabled button i.e. a grey button, rather it is just going less opaque. |
| @@ -3,6 +3,25 @@ | |||
|
|
|||
| p.instruction Hi {{vm.username}}! Your account is now active. To help other members get to know you, select the tracks in which you're interested, and specify some of your skills. You can edit this information later on your Profile. | |||
|
|
|||
| .communities(ng-show="!vm.loadingCommunities && vm.showCommunity") | |||
| .communities-title Communities | |||
There was a problem hiding this comment.
I like the BEM naming convention! We should use double underscores to signify elements, e.g. .communities__title, community__title--disabled.
-- Incorporated code review suggestions (more consistent BEM naming)
|
@nlitwin Incorporated suggested changes for BEM naming. Thanks for catching that. :) |
|
@parthshah @nlitwin @tladendo merging the PR. Please let me know if you guys find any issue with the changes. Specifically, the styling of the Done button as I mentioned above in my comments. |
…er-ios-community SUP-2728, Add iOS community to Onboarding page (Skill picker)
|
@vikasrohit Hey Vikas, sorry it took me so long! I was working locally in node_modules, and it was hard to switch branches without losing the work there haha. I just pulled down the branch and tried it out. Disabling the switch button after enabling once is showing the original, disabled, gray button. Switches on show the correct blue button :) |
|
Awesome... I don't know what is wrong with my machine. It show disabled blue button instead of disabled grey button even in incognito window. |
|
I remember a few months back, Chrome was making these weird blue boxes, and On Mon, Dec 21, 2015 at 9:58 AM, vikasrohit [email protected]
|
|
Oh! Then it seems to be the chrome's issue. May be the issue would go away when I upgrade my chrome which is pending for quite a few days. :) |
@nlitwin @tladendo @parthshah Please let me know your thoughts and suggest any thing I can improve here.
-- Added communities section
-- Communities section will be visible only if there exists at least one community for which the member is not registered yet
-- Added unit tests