This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Feature/sup 2592 #584
Merged
Feature/sup 2592 #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I consider this the first round of cleanup. I switched the errors to use ng-messages, and generally tried to make things cleaner, clearer, and less redundant. |
| // username - make sure it exists | ||
| UserService.validateUserHandle(vm.username).then(function(data) { | ||
| if (data.valid) { | ||
| // username doesn't exist | ||
| vm.usernameExists = false; | ||
| vm.loginErrors['username-nonexistant'] = true; |
There was a problem hiding this comment.
Can we have constant for the string literal? May be at the top of the controller if used only in this controller otherwise in constants object.
Same for other login error strings.
There was a problem hiding this comment.
Sure, I'll add an enum for these.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fyi @nlitwin @parthshah @vikasrohit