This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Show empty state if user has no ratings #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,7 +9,7 @@ header | |||
| section.challenges(ng-hide="vm.loading") | |||
| challenge-tile.tile(ng-repeat="challenge in vm.myChallenges", challenge="challenge", domain="vm.domain") | |||
|
|
|||
| challenge-tile.tile.spotlight(challenge="vm.spotlightChallenge", domain="vm.domain", spotlight) | |||
| challenge-tile.tile.spotlight(spotlight, challenge="vm.spotlightChallenge", domain="vm.domain") | |||
There was a problem hiding this comment.
Should we refactor this to be its own spotlight directive?
There was a problem hiding this comment.
Yup yup, we can definitely do that. I thought we were going to use challenge-tile.directive.js's templateUrl function to swap different templates, but keep the same base directive. I don't think it's a huge difference in functionality so either way works for me!
nlitwin
added a commit
that referenced
this pull request
Jul 30, 2015
Show empty state if user has no ratings
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@parthshah @tladendo let me know what you think!