This repository was archived by the owner on Mar 4, 2025. It is now read-only.
reliability link #567
Merged
reliability link #567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lets build |
| @@ -9,7 +9,7 @@ | |||
| .subtrack-stats | |||
| responsive-carousel(data="vm.subTrackStats", handle="{{vm.handle}}") | |||
| .carousel-elem | |||
| .flex-wrapper | |||
| a.flex-wrapper(ng-class="{'link': item.link, 'no-link': !item.link}", ng-href="{{item.link}}") | |||
There was a problem hiding this comment.
would it be easier to add this anchor tag with ng-if property?
There was a problem hiding this comment.
the tag should be there no matter what, the question is whether it's clickable
There was a problem hiding this comment.
I agree that that anchor tag should be there regardless, but I think <a> is still clickable, even if the cursor isn't a pointer.
There was a problem hiding this comment.
i had a problem with clicking these tags at first, but now i'm able to disable clickability.
There was a problem hiding this comment.
Ahh ok cool, how did you disable it? pointer-events?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fyi @parthshah @nlitwin