This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Added front end sorting for history graph #558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -79,6 +79,11 @@ | |||
| var desktop = window.innerWidth >= 900 && true; | |||
|
|
|||
| $scope.promise.then(function(history) { | |||
| history.sort(function(lhs, rhs) { | |||
There was a problem hiding this comment.
Does lhs and rhs stand for left and right hand side? Let's use long names in general for JavaScript to eliminate any guessing 😄 Vic and I should be adding a code styleguide soon to the readme, sorry it's taking so long!
tladendo
added a commit
that referenced
this pull request
Nov 17, 2015
Added front end sorting for history graph
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fyi @parthshah @nlitwin