Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Sup 2409 mobile dashboard #543

Merged
merged 3 commits into from
Nov 9, 2015
Merged

Sup 2409 mobile dashboard #543

merged 3 commits into from
Nov 9, 2015

Conversation

nlitwin
Copy link
Contributor

@nlitwin nlitwin commented Nov 9, 2015

Merging to test in dev on iPhone. @parthshah @vikasrohit @tladendo Let me know if you see any problems.

li.submenu-item #[a.menu-link(ng-click="$event.stopPropagation();" href="https://help.{{domain}}" target="_blank") HELP CENTER]
li.submenu-item #[a.menu-link(ng-click="$event.stopPropagation();" href="https://www.{{domain}}/community/how-it-works/privacy-policy/") PRIVACY POLICY]
li.submenu-item #[a.menu-link(ng-click="$event.stopPropagation();" href="https://www.{{domain}}/community/how-it-works/terms/") TERMS]
li.submenu-item #[a.menu-link(ng-href="https://www.{{domain}}/sitemap") SITE MAP]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes links work locally and per environment

nlitwin added a commit that referenced this pull request Nov 9, 2015
@nlitwin nlitwin merged commit dc05621 into dev Nov 9, 2015
@nlitwin nlitwin deleted the sup-2409-mobile-dashboard branch November 9, 2015 20:26
li
a(href="/my-dashboard") Dashboard
li
a(href="/members/") My Profile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is in correct? Shouldn't this be dynamic?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't make any changes to this file except adding a space between SITE and MAP, the rest is improper indenting that Sublime Text auto fixed. I haven't taken a look at the site map code - but I can make the necessary updates if we want to change it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix these. These are minor issues so hopefully it doesn't take too
long.
Thanks

On Mon, Nov 9, 2015 at 12:36 PM, Nicholas Litwin [email protected]
wrote:

In app/sitemap/sitemap.jade
#543 (comment)
:

  •    li
    
  •      a(href="//apps.topcoder.com/forums") Forums
    
  •    li
    
  •      a(href="/community/statistics") Statistics
    
  •    li
    
  •      a(href="/community/events") Events
    
  •    li
    
  •      a(href="/blog") Blog
    
  • section.sitemap-nav.hide-small
  •  h2.sitemap-header My Account
    
  •  ul
    
  •    li
    
  •      a(href="/my-dashboard") Dashboard
    
  •    li
    
  •      a(href="/members/") My Profile
    

I didn't make any changes to this file except adding a space between SITE
and MAP, the rest is improper indenting that Sublime Text auto fixed. I
haven't taken a look at the site map code - but I can make the necessary
updates if we want to change it.


Reply to this email directly or view it on GitHub
https://github.com/appirio-tech/topcoder-app/pull/543/files#r44327588.

Thanks
Parth Shah

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants