This repository was archived by the owner on Mar 4, 2025. It is now read-only.
SUP-2582, Upcoming SRMs should be ordered by most recent date #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- Fixed sorting in dashboard (ascending by registrationStartAt) -- Fixed sorting in My SRMs#Upcoming (ascending by codingStartAt) -- Fixed sorting in My SRMs#Past (ascending by codingEndAt)
| @@ -21,7 +21,7 @@ | |||
|
|
|||
| function getSRMs() { | |||
| var params = { | |||
| filter: 'status=future', | |||
| filter: 'status=future&orderBy=registrationStartAt', | |||
There was a problem hiding this comment.
'orderBy' is not a filter. It should be passed as a separate param like 'limit'
-- Incorporated code review comments
|
Incorporated changes. Please review. |
|
Looks good. Thanks! |
parthshah
added a commit
that referenced
this pull request
Nov 6, 2015
…y-registration-start SUP-2582, Upcoming SRMs should be ordered by most recent date
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Fixed sorting in dashboard (ascending by registrationStartAt)
-- Fixed sorting in My SRMs#Upcoming (ascending by codingStartAt)
-- Fixed sorting in My SRMs#Past (ascending by codingEndAt)
@parthshah @oyeanuj fyi