Fixed image saving for settings #539
Conversation
| @@ -51,7 +51,7 @@ | |||
| } | |||
| } | |||
| }); | |||
| }); | |||
| }, 400); | |||
There was a problem hiding this comment.
Does this $timeout affect the image save?
There was a problem hiding this comment.
i just put it in because without it, there was a console error. i figured whoever wrote the timeout wanted there to be an actual timeout
There was a problem hiding this comment.
I think I wrote it awhile back? I just left it blank so it'd default to 0, cause I needed it to get added to the end of the event queue. Not having an explicit time shouldn't produce an error?
There was a problem hiding this comment.
here's the error:
TypeError: Cannot read property 'currentPassword' of undefined
at Object.fn (http://local.topcoder-dev.com:3000/settings/account-info/account-info.controller.js:46:33)
at Scope.$digest (http://local.topcoder-dev.com:3000/bower_components/angular/angular.js:15715:29)
at Scope.$apply (http://local.topcoder-dev.com:3000/bower_components/angular/angular.js:15986:24)
at http://local.topcoder-dev.com:3000/bower_components/angular/angular.js:17753:36
at completeOutstandingRequest (http://local.topcoder-dev.com:3000/bower_components/angular/angular.js:5490:10)
at http://local.topcoder-dev.com:3000/bower_components/angular/angular.js:5762:7
at nrWrapper (http://local.topcoder-dev.com:3000/settings/account/:322:12787) undefined(anonymous function) @ angular.js:12416(anonymous function) @ angular.js:9203(anonymous function) @ exception-handler.provider.js:57Scope.$digest @ angular.js:15733Scope.$apply @ angular.js:15986(anonymous function) @ angular.js:17753completeOutstandingRequest @ angular.js:5490(anonymous function) @ angular.js:5762nrWrapper @ (index):322
angular.js:12416 Error: Cannot read property 'currentPassword' of undefined Object {exception: TypeError: Cannot read property 'currentPassword' of undefined
at Object.fn (http://local.topcod…, cause: undefined}
There was a problem hiding this comment.
Weird! Wonder why it stopped working haha. I guess 400ms isn't going to hurt anything :D I wish I could get rid of the $timeout completely!
There was a problem hiding this comment.
yeah, it's one of the things we should can when we refactor
Fixed image saving for settings
fyi @parthshah @nlitwin