This repository was archived by the owner on Mar 4, 2025. It is now read-only.
SUP-2398, Skill Picker-->'Done' button is getting enabled for fraction of second after clicking on to done the informations. #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n of second after clicking on to done the informations. -- Disabled the button as soon as the API calls returns success so that it does not enabled while browser is trying to navigate to dashboard. However, there is some css issue in disabled state of button with tc-busy directive.
|
Hey Vikas, I checked out the branch, navigated to /skill-picker, selected some skills, and hit done. I see the tc-busy spinner and it all looks grey/disabled to me. I can't seem to reproduce the problem. Looks like it works! |
|
Ok. I can merge the branch, however, somehow I am still getting the same issue on my local machine. Let us merge it and check it on dev so that others can also observe the situation. |
vikasrohit
pushed a commit
that referenced
this pull request
Nov 16, 2015
…n-flicker-skill-picker SUP-2398, Skill Picker-->'Done' button is getting enabled for fraction of second after clicking on to done the informations.
vikasrohit
deleted the
feature/sup-2398-done-button-flicker-skill-picker
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Disabled the button as soon as the API calls returns success so that it does not enabled while browser is trying to navigate to dashboard. However, there is some css issue in disabled state of button with tc-
busy directive.
@vic-appirio @nlitwin can you please have a look at the css issue? Basically, it is showing a blue bar after the "Done" text in the button when the button get disabled after busy state. It seems it is a bug with tc-btn-l class because if I change the button class to be tc-btn-m, it does not show that blue bar.
cc: @parthshah