This repository was archived by the owner on Mar 4, 2025. It is now read-only.
SUP-2311, Add generic error message when something fails while linking/unlinking the external account #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 4, 2015 11:10
…g/unlinking the external account -- Added generic error message when anything bad happens with link/unlink calls.
…g/unlinking the external account -- Fixed support email address link and its text
|
Lgtm :) |
parthshah
added a commit
that referenced
this pull request
Nov 4, 2015
…ling-ext-acc-link-unlink SUP-2311, Add generic error message when something fails while linking/unlinking the external account
vikasrohit
deleted the
feature/sup-2311-error-handling-ext-acc-link-unlink
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Added generic error message when anything bad happens with link/unlink calls.
@parthshah can you please quickly review it? Please I haven't wrote new tests for validating these changes because there no unit tests for the externalAccountService and that service needs some refactoring around calling the end point for adding the social profile. Further, I guess, we already have some major refactoring around external accounts, so it would be better to test it completely after those are in dev.