This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Feature/quick fixes after ga release #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 3, 2015 10:31
-- Showed the statistics tab for non rated tracks (design specifically)
* dev: fixed dashboard links Fixed spacing on design cards
-- Ordered the subtract stats by descending order of mostRecentSubmission date for the track/subtrack -- Copilot stats would always be the first one, if available.
* dev: Add test for tcsso token
| if (vm.track !== 'DESIGN') { | ||
| vm.tabs.push('statistics'); | ||
| } | ||
| vm.tabs.push('statistics'); |
There was a problem hiding this comment.
vm.tabs can be defined & initialized in the same line.
|
@vikasrohit thanks for cleaning this up. Had a few minor comments. Also, do we have any tests for this? |
|
I think there exist few tests for subtrack controller. But there are none for subtrack-stats. I would start writing them for missing ones. But should I write it down before getting it merged into dev? |
-- Incorporated changes from PR.
|
Okay, thanks for clarifying. I'll create a task for unit tests. Merging. |
parthshah
added a commit
that referenced
this pull request
Nov 4, 2015
…a-release Feature/quick fixes after ga release
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUP-2410, Fix ordering of sub-tracks on profile and dashboard
-- Ordered the subtract stats by descending order of mostRecentSubmission date for the track/subtrack
-- Copilot stats would always be the first one, if available.
SUP-2387, Dealing with stats for design and non-rated sub-tracks
-- Showed the statistics tab for non rated tracks (design specifically)
@parthshah @nlitwin @tladendo fyi