Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Sup 2361 social no password #522

Merged
merged 3 commits into from
Nov 4, 2015
Merged

Sup 2361 social no password #522

merged 3 commits into from
Nov 4, 2015

Conversation

nlitwin
Copy link
Contributor

@nlitwin nlitwin commented Nov 3, 2015

No description provided.

@nlitwin
Copy link
Contributor Author

nlitwin commented Nov 3, 2015

@tladendo @vikasrohit @thabofletcher @parthshah I actually added tests this time! :D Please review when one of you has some time, thanks

// });

xit('should return an error if the user entered an incorrect current password', function() {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add tests for this case please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argh, you saw that

nlitwin added a commit that referenced this pull request Nov 4, 2015
@nlitwin nlitwin merged commit 9894938 into dev Nov 4, 2015
@nlitwin nlitwin deleted the SUP-2361-social-no-password branch January 26, 2016 22:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants