Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Forms refactor #485

Merged
merged 17 commits into from
Oct 28, 2015
Merged

Forms refactor #485

merged 17 commits into from
Oct 28, 2015

Conversation

vic-tian
Copy link
Contributor

ALL previous issues fixed; please review

@tladendo @thabofletcher @nlitwin @parthshah Please review and merge, I have to complete form sizing and tooltips position for settings page;

Victor George added 11 commits October 26, 2015 16:15
Refactor Switch component, moved inputs into _inputs
9fc6e80
Merge branch 'dev' of github.com:appirio-tech/topcoder-app into forms…
8736549 
…-refactor

# By vikasrohit (14) and others
# Via vikasrohit (7) and others
* 'dev' of github.com:appirio-tech/topcoder-app: (30 commits)
  Revert "SUP-2257, Problem Archive link under SRM section should go to https://arena.topcoder.com/#/u/practiceProblemList."
  SUP-2160, Displayed color for Handle/Rating should be yellow SUP-2250, Grey color for handle should be more darker than current one.
  SUP-2209, User has past challenges but not able to access the past challenges from dashboard as user do not have any active challenges.
  SUP-2231, New Empty States for Dashboard and Profile
  attempting to clean up community app, moving data to a service
  SUP-2231, New Empty States for Dashboard and Profile
  refactoring controller & adding default view for /community
  reading link domain from config, refactoring api to skipAuthorization
  Added link for recent SRM color changes
  Fixed some labels
  members / statistic page updates, read top ranks from API
  SUP-2231, New Empty States for Dashboard and Profile, SUP-2209, User has past challenges but not able to access the past challenges from dashboard as user do not have any active challenges.
  SUP-2231, New Empty States for Dashboard and Profile, SUP-2209, User has past challenges but not able to access the past challenges from dashboard as user do not have any active challenges.
  SUP-2231, New Empty States for Dashboard and Profile, SUP-2231, User has past challenges but not able to access the past challenges from dashboard as user do not have any active challenges.
  SUP-2231, New Empty States for Dashboard and Profile, SUP-2231, User has past challenges but not able to access the past challenges from dashboard as user do not have any active challenges.
  SUP-2231, New Empty States for Dashboard and Profile
  SUP-1889, Dashboard UI Polish, SUP-2232, Directive for page state header
  SUP-2231, New Empty States for Dashboard and Profile
  SUP-2231, New Empty States for Dashboard and Profile
  Added sitemap links
  ...
password tips styled, settings pages styled
fc79a38
Merge branch 'dev' of github.com:appirio-tech/topcoder-app into forms…
6a135b0 
…-refactor

# By vikasrohit
# Via vikasrohit
* 'dev' of github.com:appirio-tech/topcoder-app:
  SUP-2255, Remove "Didn't Finish" from past challenges where user was not a submitter
  SUP-2250, Grey color for handle should be more darker than current one.
  SUP-2231, New Empty States for Dashboard and Profile
  SUP-2160, Displayed color for Handle/Rating should be yellow SUP-2250, Grey color for handle should be more darker than current one.
Merge branch 'dev' of https://github.com/appirio-tech/topcoder-app in…
fa36a99 
…to forms-refactor

# By Tom Ladendorf (2) and vikasrohit (2)
# Via Tom Ladendorf
* 'dev' of https://github.com/appirio-tech/topcoder-app:
  added password maxlength
  Revert "SUP-2207, "Whoops! Something went wrong. Please try again later." message while opening the profile page."
  SUP-2207, "Whoops! Something went wrong. Please try again later." message while opening the profile page.
  Added design submission viewer lightbox
code organized
24144b0
Field refactor,
21cf847 
Merge branch 'dev' of https://github.com/appirio-tech/topcoder-app into forms-refactor

# By Tom Ladendorf
# Via Tom Ladendorf (1) and Victor George (1)
* 'dev' of https://github.com/appirio-tech/topcoder-app:
  disabled button change
Merge branch 'dev' of https://github.com/appirio-tech/topcoder-app in…
d3e3c67 
…to forms-refactor

# By vikasrohit (7) and Thabo (3)
# Via vikasrohit (7) and Thabo (2)
* 'dev' of https://github.com/appirio-tech/topcoder-app:
  SUP-2312, [Registration] Social registration not working
  SUP-2197, Search box styling and ux issues
  SUP-2231, New Empty States for Dashboard and Profile
  SUP-2231, New Empty States for Dashboard and Profile
  sup-2153 fix getting started/member onboarding links
  SUP-2270, Profile is missing Country information.
  sup-2298 rename arena
  sup-2300 nav bar challenge links
  SUP-2268, Dashboard--> Challenge card--> No. of submission link is not working.
  SUP-2207, "Whoops! Something went wrong. Please try again later." message while opening the profile page.
BIG CLEANUP:
bb5dabf 
Fonts // Mixins // Inputs // Autocomplete // Registration/Login/Reset/New Password fixes
Merge branch 'dev' of github.com:appirio-tech/topcoder-app into forms…
2d86cef 
…-refactor

# By Tom Ladendorf (9) and vikasrohit (6)
# Via Tom Ladendorf (7) and vikasrohit (6)
* 'dev' of github.com:appirio-tech/topcoder-app:
  SUP-2231, New Empty States for Dashboard and Profile
  one more thing
  Country validation workaround
  Added country validation
  SUP-1741, Allow registration for SRM
  Fixed saving on account page
  SUP-2286, [Registration] Skill picker issue
  Updated image loading
  SUP-1741, Allow registration for SRM
  Added track validity check
  changed graph labels
  SUP-1741, Allow registration for SRM
  SUP-1741, Allow registration for SRM
  Fixes image deletion when no tracks selected
  Some image upload fixes

Conflicts:
	app/account/register/register.jade
	app/settings/edit-profile/edit-profile.jade
small fix // typography
65735ef
parthshah
parthshah reviewed Oct 28, 2015
View reviewed changes
app/directives/track-toggle/track-toggle.directive.jade
@@ -1,7 +1,7 @@
.track(ng-repeat="track in ['DESIGN', 'DEVELOP', 'DATA_SCIENCE']")
hr(class="{{!$index && 'first'}}")
//- hr(class="{{!$index && 'first'}}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you dont need this plz delete this row

@parthshah
Copy link
Contributor

@vic-appirio thanks this is great. I have a few comments - two main things though -

  • Why was ng-show check removed? : ```
    file-delete(ng-show="vm.userData.photoURL && vm.userData.photoURL.length")
  •            button.tc-btn.tc-btn-secondary.tc-btn-s(ng-click="vm.deleteImage()", type="button") Delete

  •          .file-delete

* I prefer we include sourceMap in QA & Dev env. We are doing this check for JS files as well.

tladendo
tladendo reviewed Oct 28, 2015
View reviewed changes
assets/css/account/account.scss
@@ -199,7 +181,7 @@
color: #A3A3AE;
font-size: 13px;
line-height: 22px;
@include sofia-pro-regular;
@include font-with-weight;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems way more ambiguous to me but i guess it's fine for now

@tladendo
Copy link
Contributor

@vic-appirio -- few things

  • password tooltip is weird, gets in the way on settings page
  • the "mandatory" field labels look super bunched together with the other text -- maybe the forms should be wider?
  • + everything parth said

Victor George added 6 commits October 28, 2015 10:31
Merge branch 'dev' of https://github.com/appirio-tech/topcoder-app in…
ff92986 
…to forms-refactor

# By Parth Shah (4) and others
# Via Parth Shah (8) and others
* 'dev' of https://github.com/appirio-tech/topcoder-app:
  SUP-2286, [Registration] Skill picker issue
  added some safeguards
  fixing skill icon
  reverted back based on review with community team
  Cutting member of month and moving copilots up
  Updated Arena to Competitive Programming
  Update communityData.service.js
  using rootscope to udpate page header directive & header controller on image / profile chnage
  enabling introjs and remove element selection as per anuj's request
  adding community home
pull request fixes
dbe9c9e
settings sizes fixed;
38586f6 
gulp-sass module updated to 2.1.0
Merge branch 'dev' of https://github.com/appirio-tech/topcoder-app in…
94a2311 
…to forms-refactor

# By Tom Ladendorf (3) and others
# Via Tom Ladendorf (4) and others
* 'dev' of https://github.com/appirio-tech/topcoder-app:
  updated track validation
  SUP-2317, Account Setting--> Spinner on 'Save' button should stop after successful message.
  -- Removed hardcoded Submit button for challenge tile
  Updated latest copy, from Anuj, for introjs stuff.
  more save button fixes
  save button fixes
  Updated Community nav per latest reqs
  Corrected image link for Ghostar
  Added 4th member of month and updated latest SRM winners

Conflicts:
	app/settings/account-info/account-info.jade
	app/settings/edit-profile/edit-profile.jade
button sizes fixed; headings
852f642
show password label tacky fixes
8c9b15a
tladendo added a commit that referenced this pull request Oct 28, 2015
@tladendo
Merge pull request #485 from appirio-tech/forms-refactor
f985225 
Forms refactor
@tladendo tladendo merged commit f985225 into dev Oct 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vic-tian @parthshah @tladendo