This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Feature/empty state directive #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
October 22, 2015 14:57
* dev: (41 commits) SUP-2241, Dashboard--> "This challenge is currently paused" should have padding on challenge card. #60 Styling "Login" and "Register" buttons in logged out state 6 or so more fixes Nav: Blue arrow for active nav item is not aligned fixed hover for skills on profile a fix for image upload styling fixing stackoverlow integration fixing image checkbox label size, removed extra images navigation fixed, new icons, new track icons Fixed mobile layout issue with challenges section another potential input fix SUP-2241, Dashboard--> "This challenge is currently paused" should have padding on challenge card. Fixed Sticky directive using v3 user endpoint SUP-2143, Dashboard--> Texts are overlapping on my challenges on mobile device. input test changes round 2 first round of changes fixing test ... Conflicts: app/my-dashboard/my-challenges/my-challenges.controller.js
-- Updated empty states for My Challenges and My SRMs pages.
-- Updated background images for empty states -- Fixed margin/paddings of non empty states as well to do styling for empty states. Moved paddings from parent elements to child elements so that we have better control on them in empty states.
-- Removed hard coded height for challenge tile for completed challenges. It was limiting the tile height to be 340px while as per specs they should 350px.
* dev: added propper class on reset password / buttons SUP-2242 dashboard and subtrack polishes profile cleanup
-- Updated learn more links to point to new onboarding page -- Removed learn more links for My Challenges page when user has participated at least once because it does not make sense to show learn more to a member who has already participated in one of the challenges.
…has past challenges but not able to access the past challenges from dashboard as user do not have any active challenges. -- Added never participation logic for challenges section on dashboard Reference for the text: https://appirio.atlassian.net/browse/SUP-2209?focusedCommentId=17437&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17437
…has past challenges but not able to access the past challenges from dashboard as user do not have any active challenges. -- Moved logic for checking participation into service. -- Reversed the call order for participation and actual data services to avoid extra calls in most of the cases.
…has past challenges but not able to access the past challenges from dashboard as user do not have any active challenges. -- Updated link for "Explore Open Challenges" button to point to "My Challenges" page with Past filter.
…has past challenges but not able to access the past challenges from dashboard as user do not have any active challenges. -- Updated the text for upsell buttons along with pointing the "Explore Open Challenges" button to point to My Challenges with Past filter to be consistent with dashboard. However, the use case should never appear where we show the empty state for past challenges.
-- Refactored the empty state directive to accommodate dynamic content html between title and description -- Created service for empty state data -- Added support for themes in empty state directive to avoid any css set in parent page's css -- Added empty states for profile page (skills, activity, external links)
-- Updated margins in non empty states to accommodate empty state changes.
* dev: (27 commits) attempting to clean up community app, moving data to a service refactoring controller & adding default view for /community reading link domain from config, refactoring api to skipAuthorization updating version Added link for recent SRM color changes SUP-2257, Problem Archive link under SRM section should go to https://arena.topcoder.com/#/u/practiceProblemList. SUP-2260, Forum Posts link on profile is wrong URL. Should use apps.topcoder.com/forums as the base SUP-2245, Dashboard--> Practice on past problems card is 2 pixel less in length. SUP-2232, Dashboard--> Lean more link path is not correct. fixing social registration problem Fixed some labels members / statistic page updates, read top ranks from API added "Get Started" link to main navigation Added sitemap links fixing test Renamed Tops Added review board session and wired up member search to existing search page. Sitemap updating v3 endpoint Added static content and links for members page ... Conflicts: app/index.jade
…allenges from dashboard as user do not have any active challenges. -- Updated explore links back to active challenges page (as per latest comments in the JIRA) -- Updated logic for showing the section containing the buttons for viewing active/past challenges page
vikasrohit
pushed a commit
that referenced
this pull request
Oct 26, 2015
Feature/empty state directive @parthshah merging so that we can get enough time before GA release. However, I am still open for any suggestion.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@parthshah @nlitwin @tladendo fyi
Please let me know if I broke any existing stuff.