This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Feature/non winner state past challenges #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 14, 2015 17:41
…re is no winner -- Added parsing function call for processing past challenges.
…re is no winner -- created directives for dev and design user placement ui -- extracted styles for directives from challenge-tile styles -- moved design challenge placement processing logic to challenge service -- fixed issue with missing placements for past challenges
vikasrohit
pushed a commit
that referenced
this pull request
Oct 15, 2015
…st-challenges Feature/non winner state past challenges
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- created directives for dev and design user placement ui
-- extracted styles for directives from challenge-tile styles
-- moved design challenge placement processing logic to challenge service
-- fixed issue with missing placements for past challenges
@parthshah @nlitwin @tladendo please note I have created a separate directive for rendering user placement in challenge tiles. Please let me know if seems to break anything your respective modules.